Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csv allow only header and fix lazy rename #3423

Merged
merged 1 commit into from
May 18, 2022
Merged

csv allow only header and fix lazy rename #3423

merged 1 commit into from
May 18, 2022

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented May 18, 2022

fixes #3384
fixes #3361

@github-actions github-actions bot added the rust Related to Rust Polars label May 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3423 (20173b6) into master (7911011) will decrease coverage by 0.00%.
The diff coverage is 20.83%.

❗ Current head 20173b6 differs from pull request most recent head 1301215. Consider uploading reports for the commit 1301215 to get more accurate results

@@            Coverage Diff             @@
##           master    #3423      +/-   ##
==========================================
- Coverage   61.59%   61.59%   -0.01%     
==========================================
  Files         396      396              
  Lines       68573    68592      +19     
==========================================
+ Hits        42238    42248      +10     
- Misses      26335    26344       +9     
Impacted Files Coverage Δ
polars/polars-io/src/csv_core/utils.rs 70.57% <0.00%> (-3.00%) ⬇️
polars/polars-io/src/csv_core/parser.rs 81.53% <71.42%> (-0.17%) ⬇️
...olars/polars-core/src/frame/groupby/into_groups.rs 48.35% <0.00%> (-0.74%) ⬇️
polars/polars-io/src/csv_core/buffer.rs 78.47% <0.00%> (+0.26%) ⬆️
polars/polars-core/src/frame/asof_join/groups.rs 77.02% <0.00%> (+0.51%) ⬆️
...ars/polars-core/src/chunked_array/ops/any_value.rs 69.91% <0.00%> (+0.88%) ⬆️
polars/polars-core/src/vector_hasher.rs 71.23% <0.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7911011...1301215. Read the comment docs.

@github-actions github-actions bot added the python Related to Python Polars label May 18, 2022
@ritchie46 ritchie46 changed the title csv allow only header csv allow only header and fix lazy rename May 18, 2022
@ritchie46 ritchie46 merged commit 558a179 into master May 18, 2022
@ritchie46 ritchie46 deleted the csv_err branch May 18, 2022 09:19
moritzwilksch pushed a commit to moritzwilksch/polars that referenced this pull request May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to Python Polars rust Related to Rust Polars
Projects
None yet
2 participants