Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve struct #3468

Merged
merged 3 commits into from
May 22, 2022
Merged

Improve struct #3468

merged 3 commits into from
May 22, 2022

Conversation

ritchie46
Copy link
Member

fixes #3464
fixes #3465
fixes #3461

@github-actions github-actions bot added python Related to Python Polars rust Related to Rust Polars labels May 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3468 (9b06b73) into master (edc4dbd) will decrease coverage by 4.98%.
The diff coverage is 95.04%.

@@            Coverage Diff             @@
##           master    #3468      +/-   ##
==========================================
- Coverage   77.53%   72.54%   -4.99%     
==========================================
  Files         404      406       +2     
  Lines       69639    69746     +107     
==========================================
- Hits        53992    50597    -3395     
- Misses      15647    19149    +3502     
Impacted Files Coverage Δ
polars/polars-arrow/src/kernels/rolling/mod.rs 94.80% <ø> (ø)
.../polars-arrow/src/kernels/rolling/no_nulls/mean.rs 50.94% <ø> (ø)
...s/polars-arrow/src/kernels/rolling/no_nulls/mod.rs 86.73% <ø> (ø)
...ars-arrow/src/kernels/rolling/no_nulls/quantile.rs 95.31% <ø> (ø)
...s/polars-arrow/src/kernels/rolling/no_nulls/sum.rs 92.12% <ø> (ø)
.../polars-arrow/src/kernels/rolling/nulls/min_max.rs 89.09% <ø> (ø)
...polars-arrow/src/kernels/rolling/nulls/quantile.rs 86.45% <ø> (ø)
py-polars/src/series.rs 76.63% <0.00%> (-0.06%) ⬇️
...lars/polars-arrow/src/kernels/rolling/nulls/sum.rs 92.72% <92.72%> (ø)
...ars/polars-arrow/src/kernels/rolling/nulls/mean.rs 98.03% <98.03%> (ø)
... and 142 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a39576...9b06b73. Read the comment docs.

@ritchie46 ritchie46 merged commit 69c57d4 into master May 22, 2022
@ritchie46 ritchie46 deleted the improve_struct branch May 22, 2022 09:01
moritzwilksch pushed a commit to moritzwilksch/polars that referenced this pull request May 29, 2022
* struct check field names not dtypes

* implement Series::full_null for Struct

* fix unique for struct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to Python Polars rust Related to Rust Polars
Projects
None yet
2 participants