Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce probability of quadratic behavior in min/max rolling #3516

Merged
merged 3 commits into from
May 27, 2022
Merged

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added the python Related to Python Polars label May 27, 2022
@github-actions github-actions bot added the rust Related to Rust Polars label May 27, 2022
@ritchie46 ritchie46 changed the title python polars 0.13.39 reduce probability of quadratic behavior in min/max rolling May 27, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3516 (ffcd5d7) into master (4aef113) will decrease coverage by 0.46%.
The diff coverage is 68.01%.

❗ Current head ffcd5d7 differs from pull request most recent head 6b02645. Consider uploading reports for the commit 6b02645 to get more accurate results

@@            Coverage Diff             @@
##           master    #3516      +/-   ##
==========================================
- Coverage   77.73%   77.27%   -0.47%     
==========================================
  Files         411      425      +14     
  Lines       70368    70621     +253     
==========================================
- Hits        54704    54569     -135     
- Misses      15664    16052     +388     
Impacted Files Coverage Δ
.../polars-arrow/src/kernels/rolling/no_nulls/mean.rs 50.94% <ø> (ø)
...ars-arrow/src/kernels/rolling/no_nulls/quantile.rs 68.69% <0.00%> (-26.63%) ⬇️
...ars/polars-arrow/src/kernels/rolling/nulls/mean.rs 84.00% <ø> (-14.00%) ⬇️
polars/polars-core/src/chunked_array/ops/mod.rs 19.87% <0.00%> (ø)
...olars-core/src/chunked_array/ops/rolling_window.rs 86.39% <0.00%> (-8.93%) ⬇️
polars/polars-core/src/datatypes.rs 70.34% <ø> (ø)
polars/polars-core/src/series/mod.rs 63.32% <ø> (+5.36%) ⬆️
polars/polars-core/src/series/series_trait.rs 23.24% <0.00%> (+2.44%) ⬆️
polars/polars-time/src/chunkedarray/mod.rs 0.00% <ø> (ø)
polars/polars-time/src/lib.rs 100.00% <ø> (ø)
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 682663d...6b02645. Read the comment docs.

@ritchie46 ritchie46 merged commit a9d2298 into master May 27, 2022
@ritchie46 ritchie46 deleted the dev branch May 27, 2022 18:43
moritzwilksch pushed a commit to moritzwilksch/polars that referenced this pull request May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants