Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test sortedness propagation #3560

Merged
merged 1 commit into from
Jun 2, 2022
Merged

test sortedness propagation #3560

merged 1 commit into from
Jun 2, 2022

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Jun 2, 2022

See https://stackoverflow.com/a/72466798/6717054 how we by simply propagating metadata can ensure we have the really fast happy paths.

@github-actions github-actions bot added python Related to Python Polars rust Related to Rust Polars labels Jun 2, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3560 (25430a0) into master (a98438b) will decrease coverage by 0.00%.
The diff coverage is 84.00%.

@@            Coverage Diff             @@
##           master    #3560      +/-   ##
==========================================
- Coverage   77.60%   77.59%   -0.01%     
==========================================
  Files         425      425              
  Lines       71298    71374      +76     
==========================================
+ Hits        55331    55385      +54     
- Misses      15967    15989      +22     
Impacted Files Coverage Δ
...polars-core/src/series/implementations/duration.rs 23.09% <0.00%> (-0.16%) ⬇️
polars/polars-core/src/series/series_trait.rs 22.43% <0.00%> (ø)
polars/polars-core/src/frame/explode.rs 94.50% <54.54%> (-1.57%) ⬇️
...lars-core/src/series/implementations/dates_time.rs 56.60% <83.33%> (+0.05%) ⬆️
...polars-core/src/series/implementations/datetime.rs 44.46% <83.33%> (+0.39%) ⬆️
...s/polars-core/src/series/implementations/floats.rs 64.02% <83.33%> (+0.21%) ⬆️
...ars/polars-core/src/series/implementations/utf8.rs 69.89% <83.33%> (+0.18%) ⬆️
...lars/polars-core/src/series/implementations/mod.rs 79.37% <100.00%> (+0.16%) ⬆️
polars/polars-lazy/src/frame/mod.rs 88.31% <100.00%> (+0.34%) ⬆️
py-polars/src/series.rs 77.13% <100.00%> (+0.26%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a98438b...25430a0. Read the comment docs.

@ritchie46 ritchie46 merged commit f1df2cb into master Jun 2, 2022
@ritchie46 ritchie46 deleted the sortedness_propagate branch June 2, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants