Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update boolean aggregates and ensure they return IdxSize #3563

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

ritchie46
Copy link
Member

fixes #3511

@github-actions github-actions bot added the rust Related to Rust Polars label Jun 2, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3563 (9851d99) into master (f1df2cb) will decrease coverage by 7.87%.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##           master    #3563      +/-   ##
==========================================
- Coverage   77.57%   69.69%   -7.88%     
==========================================
  Files         425      425              
  Lines       71364    71356       -8     
==========================================
- Hits        55362    49733    -5629     
- Misses      16002    21623    +5621     
Impacted Files Coverage Δ
...ars/polars-core/src/chunked_array/ops/aggregate.rs 93.70% <90.47%> (-0.55%) ⬇️
polars/polars-io/src/tests.rs 0.00% <0.00%> (-100.00%) ⬇️
polars/polars-lazy/src/lib.rs 0.00% <0.00%> (-100.00%) ⬇️
polars/polars-time/src/lib.rs 0.00% <0.00%> (-100.00%) ⬇️
polars/polars-utils/src/lib.rs 0.00% <0.00%> (-100.00%) ⬇️
polars/polars-io/src/prelude.rs 0.00% <0.00%> (-100.00%) ⬇️
polars/polars-time/src/windows/test.rs 0.00% <0.00%> (-100.00%) ⬇️
...s-lazy/src/physical_plan/expressions/group_iter.rs 0.00% <0.00%> (-94.00%) ⬇️
polars/polars-io/src/parquet/mod.rs 0.00% <0.00%> (-93.55%) ⬇️
polars/polars-lazy/src/dsl/options.rs 0.00% <0.00%> (-88.89%) ⬇️
... and 172 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 322f1ed...9851d99. Read the comment docs.

@ritchie46 ritchie46 changed the title update booelan aggregates and ensure they return IdxSize update boolean aggregates and ensure they return IdxSize Jun 3, 2022
@ritchie46 ritchie46 merged commit e5f3173 into master Jun 3, 2022
@ritchie46 ritchie46 deleted the boolean_aggs branch June 3, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

polars-u64-idx: frame_equal fails when number of rows reaches 2^32
2 participants