Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid fast path of sorted joins and improve sortedness propagation #3577

Merged
merged 3 commits into from
Jun 5, 2022

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added python Related to Python Polars rust Related to Rust Polars labels Jun 5, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3577 (2dc2de4) into master (6b32fa8) will increase coverage by 0.26%.
The diff coverage is 25.31%.

@@            Coverage Diff             @@
##           master    #3577      +/-   ##
==========================================
+ Coverage   61.27%   61.53%   +0.26%     
==========================================
  Files         427      427              
  Lines       71429    71472      +43     
==========================================
+ Hits        43768    43981     +213     
+ Misses      27661    27491     -170     
Impacted Files Coverage Δ
...lars/polars-arrow/src/kernels/sorted_join/inner.rs 68.05% <ø> (+68.05%) ⬆️
polars/polars-core/src/chunked_array/mod.rs 51.93% <0.00%> (-0.65%) ⬇️
...rs-core/src/chunked_array/ops/take/take_chunked.rs 0.00% <0.00%> (ø)
polars/polars-core/src/frame/hash_join/mod.rs 41.87% <0.00%> (+0.45%) ⬆️
.../polars-core/src/series/implementations/boolean.rs 45.95% <0.00%> (ø)
...ars-core/src/series/implementations/categorical.rs 60.06% <0.00%> (ø)
...lars-core/src/series/implementations/dates_time.rs 32.73% <0.00%> (ø)
...polars-core/src/series/implementations/datetime.rs 44.46% <0.00%> (ø)
...polars-core/src/series/implementations/duration.rs 22.44% <0.00%> (ø)
...s/polars-core/src/series/implementations/floats.rs 56.87% <0.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b32fa8...2dc2de4. Read the comment docs.

@ritchie46 ritchie46 merged commit fe771f5 into master Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants