Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent expensive type coercion in expression and fix when->then->oth… #3579

Merged
merged 1 commit into from
Jun 5, 2022

Conversation

ritchie46
Copy link
Member

…eriwise fill null for list

@github-actions github-actions bot added python Related to Python Polars rust Related to Rust Polars labels Jun 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2022

Codecov Report

Merging #3579 (a78d7d9) into master (fe771f5) will increase coverage by 0.02%.
The diff coverage is 64.00%.

@@            Coverage Diff             @@
##           master    #3579      +/-   ##
==========================================
+ Coverage   61.55%   61.58%   +0.02%     
==========================================
  Files         427      427              
  Lines       71472    71512      +40     
==========================================
+ Hits        43995    44038      +43     
+ Misses      27477    27474       -3     
Impacted Files Coverage Δ
polars/polars-lazy/src/logical_plan/format.rs 20.89% <0.00%> (ø)
py-polars/polars/internals/expr.py 95.67% <ø> (ø)
polars/polars-lazy/src/logical_plan/lit.rs 45.07% <35.29%> (-3.08%) ⬇️
polars/polars-core/src/datatypes.rs 46.79% <53.84%> (-0.02%) ⬇️
polars/polars-lazy/src/dsl/list.rs 90.36% <100.00%> (ø)
...s-lazy/src/logical_plan/optimizer/type_coercion.rs 80.86% <100.00%> (-0.42%) ⬇️
.../polars-lazy/src/physical_plan/expressions/cast.rs 50.00% <100.00%> (+5.26%) ⬆️
py-polars/polars/internals/whenthen.py 97.14% <100.00%> (ø)
...lars/polars-core/src/chunked_array/builder/list.rs 60.17% <0.00%> (-1.72%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe771f5...a78d7d9. Read the comment docs.

@ritchie46 ritchie46 merged commit fc5bcf0 into master Jun 5, 2022
@ritchie46 ritchie46 deleted the dev branch June 5, 2022 17:06
@ghuls ghuls mentioned this pull request Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants