Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duration computation #3790

Merged
merged 1 commit into from
Jun 24, 2022
Merged

fix duration computation #3790

merged 1 commit into from
Jun 24, 2022

Conversation

ritchie46
Copy link
Member

fixes #3786

@github-actions github-actions bot added python Related to Python Polars rust Related to Rust Polars labels Jun 23, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3790 (9404e24) into master (bdb1dd0) will decrease coverage by 0.08%.
The diff coverage is 91.35%.

@@            Coverage Diff             @@
##           master    #3790      +/-   ##
==========================================
- Coverage   63.01%   62.92%   -0.09%     
==========================================
  Files         439      440       +1     
  Lines       71853    72452     +599     
==========================================
+ Hits        45280    45594     +314     
- Misses      26573    26858     +285     
Impacted Files Coverage Δ
polars/polars-lazy/src/dummies.rs 0.00% <0.00%> (ø)
polars/polars-lazy/src/logical_plan/aexpr.rs 79.51% <ø> (ø)
polars/polars-lazy/src/logical_plan/alp.rs 77.14% <ø> (-0.20%) ⬇️
polars/polars-lazy/src/logical_plan/mod.rs 90.90% <ø> (ø)
...lars/polars-lazy/src/logical_plan/optimizer/mod.rs 100.00% <ø> (ø)
...c/logical_plan/optimizer/predicate_pushdown/mod.rs 79.13% <ø> (ø)
...src/physical_plan/executors/groupby_partitioned.rs 80.92% <ø> (-0.10%) ⬇️
...rs/polars-lazy/src/physical_plan/executors/join.rs 74.46% <0.00%> (-0.81%) ⬇️
...ars/polars-lazy/src/physical_plan/executors/mod.rs 90.84% <ø> (ø)
...polars-lazy/src/physical_plan/expressions/apply.rs 93.41% <ø> (ø)
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb81c86...9404e24. Read the comment docs.

@ritchie46 ritchie46 merged commit 128550b into master Jun 24, 2022
@ritchie46 ritchie46 deleted the fix_duration branch June 24, 2022 05:46
joshuataylor pushed a commit to joshuataylor/polars that referenced this pull request Jun 24, 2022
cnpryer pushed a commit to cnpryer/polars that referenced this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

polars.duration: produces wrong values in some circumstances
2 participants