Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flake8] Enable flake8-bugbear extension #4073

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

stinodego
Copy link
Member

Relates to #4044

Changes:

  • Enabled the flake8-bugbear extension. (flake8 extensions are enabled simply by being installed in the same environment as flake8)
  • Fixed the resulting linting errors. Some of the more interesting ones:
    • B009: There is some inconsistency in type hints when it comes to DataTypes vs instantiated DataTypes. We should look into this at some point. For now, replaced the getattr with the proper usage and ignored the resulting mypy error.
    • B006: The deepcopy function definition was a fun rabbithole... apparently the optional memo is required, but this is very poorly documented. We do not use it, so we can just set it to None. (for reference, the pandas DataFrame deepcopy does the same)

@github-actions github-actions bot added the python Related to Python Polars label Jul 18, 2022
@ritchie46 ritchie46 merged commit cf82cf3 into pola-rs:master Jul 19, 2022
cnpryer pushed a commit to cnpryer/polars that referenced this pull request Jul 19, 2022
@stinodego stinodego deleted the flake8-bugbear branch July 23, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants