Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python datetime consistency #4221

Merged
merged 1 commit into from Aug 2, 2022
Merged

python datetime consistency #4221

merged 1 commit into from Aug 2, 2022

Conversation

ritchie46
Copy link
Member

fixes #4216

@github-actions github-actions bot added the python Related to Python Polars label Aug 2, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4221 (fad4dba) into master (ec4f7e8) will increase coverage by 15.16%.
The diff coverage is 100.00%.

❗ Current head fad4dba differs from pull request most recent head 0494be2. Consider uploading reports for the commit 0494be2 to get more accurate results

@@             Coverage Diff             @@
##           master    #4221       +/-   ##
===========================================
+ Coverage   64.14%   79.30%   +15.16%     
===========================================
  Files         458      459        +1     
  Lines       75650    75951      +301     
===========================================
+ Hits        48522    60232    +11710     
+ Misses      27128    15719    -11409     
Impacted Files Coverage Δ
py-polars/polars/internals/construction.py 98.06% <100.00%> (-0.31%) ⬇️
py-polars/src/conversion.rs 78.57% <100.00%> (ø)
...olars-lazy/src/physical_plan/expressions/column.rs 63.63% <0.00%> (-10.05%) ⬇️
polars/polars-io/src/parquet/predicates.rs 71.18% <0.00%> (ø)
polars/polars-lazy/src/lib.rs 100.00% <0.00%> (ø)
polars/polars-lazy/src/logical_plan/iterator.rs 98.02% <0.00%> (+0.24%) ⬆️
...olars/polars-core/src/frame/groupby/into_groups.rs 60.47% <0.00%> (+0.29%) ⬆️
polars/polars-io/src/csv/read_impl.rs 80.35% <0.00%> (+0.39%) ⬆️
...polars-lazy/src/physical_plan/expressions/apply.rs 94.18% <0.00%> (+0.58%) ⬆️
... and 206 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec4f7e8...0494be2. Read the comment docs.

@ritchie46 ritchie46 merged commit d1b4d02 into master Aug 2, 2022
@ritchie46 ritchie46 deleted the datetime_tu branch August 2, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datatime parsed by from_dict and from_dicts are different
2 participants