fix[python]: Fix datatype pickling #4621
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the
__reduce__
phase of a parametric dtype likepl.Datatime("ns")
pickling we get:,but
copyreg
's reconstructor calls__new__
which we changed to make sure we can support singleton type objects:here,
object.__new__(cls)
returns the cls itself not an instance. We need to have a custom reconstructor in order to get this to work.