Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format_str to lazy expressions API #4693

Merged
merged 6 commits into from
Sep 3, 2022
Merged

Conversation

hpux735
Copy link
Contributor

@hpux735 hpux735 commented Sep 2, 2022

To support other algorithm development, and to match python behavior, it was necessary to implement the format function. In Rust, because there's a macro named format! I thought it best to name it format_str to avoid confusion. This function should have similar time performance as concat_str, because it only scans the format string once, and it's implemented via concat_str. It should, also, be linear time.

@github-actions github-actions bot added the rust Related to Rust Polars label Sep 2, 2022
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have a small remark.

polars/polars-lazy/src/tests/functions.rs Outdated Show resolved Hide resolved
@ritchie46 ritchie46 merged commit fb0aaa3 into pola-rs:master Sep 3, 2022
@hpux735 hpux735 mentioned this pull request Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants