Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(python): Properly deprecate groupby.pivot #6000

Merged
merged 1 commit into from
Jan 3, 2023
Merged

chore(python): Properly deprecate groupby.pivot #6000

merged 1 commit into from
Jan 3, 2023

Conversation

stinodego
Copy link
Member

Changes:

  • Deprecate Groupby.pivot in favor of DataFrame.pivot. Apparently, PivotOps had been deprecated since 0.13.23 with this message, but a DeprecationWarning was never added.
  • Rewrite an unrelated test, test_glimpse, because it relied on trailing whitespace which my editor strips automatically.

This will be followed by a breaking PR removing the Groupby.pivot method and the PivotOps class.

@github-actions github-actions bot added chore Maintenance work that does not impact the user python Related to Python Polars labels Jan 2, 2023
@ritchie46 ritchie46 merged commit 14f4736 into pola-rs:master Jan 3, 2023
zundertj pushed a commit to zundertj/polars that referenced this pull request Jan 7, 2023
@stinodego @zundertj
chore(python): Properly deprecate groupby.pivot (pola-rs#6000)
8cf4909
@stinodego stinodego deleted the move-pivot branch February 22, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore Maintenance work that does not impact the user python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stinodego @ritchie46