chore(python): Deprecate more non-keyword arguments #7030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
stinodego
force-pushed
the
more-nonkeyword-depr
branch
2 times, most recently
from
03808ea
to
70e7494
Compare
stinodego
changed the title
stinodego
removed
the
enhancement
github-actions
bot
added
the
chore
|
@stinodego |
That's in the PR; not sure what you're missing? |
Sorry, missed it. |
stinodego
force-pushed
the
more-nonkeyword-depr
branch
from
70e7494
to
3db3e0c
Compare
stinodego
force-pushed
the
more-nonkeyword-depr
branch
from
3db3e0c
to
7b524da
Compare
|
I'll go ahead and merge this as the strategy implemented here has been discussed previously. |
stinodego
changed the title
josemasar
pushed a commit
to josemasar/polars
that referenced
this pull request
Feb 21, 2023
josemasar
pushed a commit
to josemasar/polars
that referenced
this pull request
Feb 22, 2023
josemasar
pushed a commit
to josemasar/polars
that referenced
this pull request
Feb 22, 2023
josemasar
pushed a commit
to josemasar/polars
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #6993
I did everything except Series/Expr, which are a bit more involved due to the dispatch decorator.
In fact, could we just not deprecate these and just break them in the next breaking release? That would save a lot of hassle. Or I could add an unsilence-able
DeprecationWarningon theExprside for the affected methods, but that would be a little annoying for the user 馃槙