chore(python): Rename args f/func to function
#7032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
|
DataFrame.pivot(aggregate_fn) comes to mind as something with an “fn”. I’m not sure if you’re also looking for cases like that. |
|
Ah yeah I forgot that one. Not 100% sure what that should be named. I'll do that in a separate PR probably. It's a bit different as it doesn't take function input. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no consensus on arguments that take function inputs: I saw
f,fn, andfunc. I went withfunctionto standardize all. These are not keyword-only arguments, so brevity doesn't count for much.Note that
pipestill hasfuncas argument, as I could not find a way to deprecate it nicely (decorator doesn't work due to that function taking*argsand**kwargs). So I think we'll just have to hard break that one.