refactor(python): Add TYPE_CHECKING lints
#7070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
stinodego
changed the title
TYPE_CHECKING lintsTYPE_CHECKING lints
github-actions
bot
added
the
refactor
josemasar
pushed a commit
to josemasar/polars
that referenced
this pull request
Feb 21, 2023
josemasar
pushed a commit
to josemasar/polars
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the TCH lints, which detects imports that are only used during type checking, and tells you to move them into an
if TYPE_CHECKINGblock.This has a slight performance benefit, but is also nice for readability, to easily discern which imports are used for type hints and which are actually used in the code logic.
I also removed the
_DOCUMENTING = Trueflags as they weren't being used - usedcontextlib.suppress(ImportError)instead.