Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rust): Replace num with num-traits + a few minor maintenance fixes #7201

Merged
merged 6 commits into from
Feb 26, 2023

Conversation

aldanor
Copy link
Contributor

@aldanor aldanor commented Feb 26, 2023

  • Drop num dependency in favor of num-traits (that's all that's being currently used anyway)
    • This removes four crates from the dependency tree: num, num-iter, num-bigint, num-rational
  • Fix various build warnings appearing when some features are enabled/disabled
  • Fix memchr version in polars-ops manifest
  • Remove unneeded jemallocator dummy feature in polars-sql (also causing a build warning)
  • In py-polars conversion, use pre-cached modules instead of importing them by hand on every conversion
  • In py-polars conversion, query the type name of an object at most once if needed
  • Update py-polars to 0.16.9 in Cargo.lock (not sure it should be bumped right away? but it comes up in git diff every time you run tests)

@aldanor aldanor force-pushed the feature/num-traits-and-fixes branch 2 times, most recently from e554ef9 to 2c09ea3 Compare February 26, 2023 13:47
@ritchie46
Copy link
Member

Thanks a lot. Sounds like a great maintenance run.

@ritchie46 ritchie46 changed the title Replace num with num-traits + a few minor maintenance fixes chore(rust): Replace num with num-traits + a few minor maintenance fixes Feb 26, 2023
@ritchie46 ritchie46 merged commit 06cac04 into pola-rs:master Feb 26, 2023
@github-actions github-actions bot added chore Maintenance work that does not impact the user rust Related to Rust Polars labels Feb 26, 2023
@aldanor aldanor deleted the feature/num-traits-and-fixes branch February 26, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance work that does not impact the user rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants