-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust, python): auto-infer fmt for tz-aware date strings #7405
Conversation
One month later, finally marking this as 'ready-for-review' 🎉 @ritchie46 @alexander-beedie in case you have time / want to take a look |
Thanks @MarcoGorelli. Could you help me a bit with the review. What have you changed? What are expected performance implications and which snippets are the gist of the changes? |
Sure! The main thing is that this PR expands pub enum Pattern {
DateDMY,
DateYMD,
DatetimeYMD,
DatetimeDMY,
+ DatetimeYMDZ,
} to include To keep track of the offset, I've also changed return type of
To deal with the offset, I've introduced The rest is mostly just updating based on the above. Just like with parsing with an explicit I don't think there should be any performance implications. A timing test I've done doesn't show any difference in performance for |
3d85e4a
to
9801f05
Compare
Thanks for the explanation. This makes the review so much easier. 👍 The code looks good and the rationale of expanding the tz aware functionality make sense, so merging in. Thanks a lot! |
…#7405) Co-authored-by: MarcoGorelli <>
…#7405) Co-authored-by: MarcoGorelli <>
closes #7198
check this out
limitations:
'%+'
, but the list can be expanded laterread_csv
, but...it should make it possible!