-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): Write dataframes as delta tables #7616
Conversation
Hey @chitralverma , just a quick check: I see you have a PR out at delta-rs for supporting LargeBinary/LargeString. Have you also thought about supporting LargeList? This is another 'blocker' I had identified. |
let me add that to the existing PR as well |
Maybe casting unsigned -> signed integers should also be added on the |
This I think we will have to do on our side I think. but I can check with the delta team |
We can definitely do that on the Polars side, but if you're mapping Arrow types to Delta supported types in I'd suggest trying to cast to a signed integer of the same bit size, and raising an error when this is not possible. |
Done! added Now the following remain,
|
long time! So we have a new rust release for |
Finally, the delta-rs release is in place and I can start working on this again |
Signed-off-by: Chitral Verma <chitralverma@gmail.com>
Signed-off-by: Chitral Verma <chitralverma@gmail.com>
Signed-off-by: Chitral Verma <chitralverma@gmail.com>
@stinodego @ritchie46 finally marked this as ready for review! |
Amazing! Reviewing this later today. |
I read the code. Not that familiar with delta-tables' API, so I will leave this one to @stinodego. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few remarks.
Co-authored-by: Stijn de Gooijer <stijn@degooijer.io>
@stinodego thanks for the review. made the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Looks like all is in order.
Signed-off-by: Chitral Verma <chitralverma@gmail.com> Co-authored-by: Stijn de Gooijer <stijn@degooijer.io>
Signed-off-by: Chitral Verma <chitralverma@gmail.com> Co-authored-by: Stijn de Gooijer <stijn@degooijer.io>
Signed-off-by: Chitral Verma <chitralverma@gmail.com> Co-authored-by: Stijn de Gooijer <stijn@degooijer.io>
Allows users to write a Polars DataFrame as a delta lake table.
[Currently, this is a work in progress as its blocked by https://github.com/delta-io/delta-rs/pull/1044]Checklist
Closes #2858 and #7574