refactor(python,rust)!: rename toggle_string_cache to enable_string_cache
#7970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
breaking
alexander-beedie
force-pushed
the
enable-string-cache
branch
from
ce9fedc
to
45ce1d1
Compare
chitralverma
pushed a commit
to chitralverma/polars
that referenced
this pull request
Apr 4, 2023
alicja-januszkiewicz
pushed a commit
to alicja-januszkiewicz/polars
that referenced
this pull request
Apr 17, 2023
chitralverma
pushed a commit
to chitralverma/polars
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #7815 (breaking changes for
0.17).Have kept a Python-side redirect (with a suitable deprecation warning) for
toggle_string_cache→enable_string_cachefor now; can remove to complete the transition. Change is breaking on the Rust side.Also, spotted that the string-cache state was leaking between doctests; this is now handled in the per-test teardown.