Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust,python): sql BETWEEN bounds should be inclusive #8818

Merged
merged 1 commit into from May 12, 2023
Merged

fix(rust,python): sql BETWEEN bounds should be inclusive #8818

merged 1 commit into from May 12, 2023

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented May 12, 2023 •
edited

Closes #8817.
Tweaked test coverage to catch the range bounds and better-validate behaviour.

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels May 12, 2023
@alexander-beedie alexander-beedie added the A-sql Area: Polars SQL functionality label May 12, 2023
@lucazanna
Copy link

16 minutes from posting an issue to a PR that fixes it being submitted

I have yet to see anyone who can beat this :)

universalmind303
universalmind303 approved these changes May 12, 2023
View reviewed changes
Copy link
Collaborator

@universalmind303 universalmind303 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should probably be scoped to all: (python, rust, cli) instead of just (rust)

@alexander-beedie
Copy link
Collaborator Author

alexander-beedie commented May 12, 2023 •
edited

This PR should probably be scoped to all: (python, rust, cli) instead of just (rust)

True; I tend to think of it in terms of "which language did I touch to fix it", but it's better to think "which implementations are affected BY the fix".

@universalmind303: added a cli label for you - feel free to request a different colour! ;)

@alexander-beedie alexander-beedie added python Related to Python Polars cli labels May 12, 2023
@alexander-beedie alexander-beedie changed the title fix(rust): sql BETWEEN bounds should be inclusive fix(rust,python): sql BETWEEN bounds should be inclusive May 12, 2023
@alexander-beedie alexander-beedie merged commit 528590c into pola-rs:main May 12, 2023
17 checks passed
@alexander-beedie alexander-beedie deleted the fix-sql-between branch May 12, 2023 15:41
ritchie46 pushed a commit that referenced this pull request May 20, 2023
@alexander-beedie @ritchie46
fix(rust,python): sql BETWEEN bounds should be inclusive (#8818)
5b24016
alexander-beedie added a commit to alexander-beedie/polars that referenced this pull request May 20, 2023
@alexander-beedie
fix(rust,python): sql BETWEEN bounds should be inclusive (pola-rs#8818
01e1a2d 
)
c-peters pushed a commit to c-peters/polars that referenced this pull request Jul 14, 2023
@alexander-beedie @c-peters
fix(rust,python): sql BETWEEN bounds should be inclusive (pola-rs#8818
aa34f04 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@universalmind303 universalmind303 universalmind303 approved these changes

Assignees
No one assigned
Labels
A-sql Area: Polars SQL functionality fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL: BETWEEN beginning and end values should be inclusive
3 participants
@alexander-beedie @lucazanna @universalmind303