feat(cli,rust,python): add sql compound identifiers #8934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
ritchie46
reviewed
May 19, 2023
polars/polars-sql/src/sql_expr.rs
Outdated
| @@ -99,15 +101,31 @@ impl SqlExprVisitor<'_> { | |||
| idents.len() == 2, | |||
| ComputeError: "compound identifier {:?} is not yet supported", idents, | |||
There was a problem hiding this comment.
I think we should change this error message. As we do support "compound identifiers".
It is not clear to me what it means to have idents > 2, but I think the message should reflect what we don't support in that case.
ritchie46
approved these changes
May 19, 2023
alexander-beedie
pushed a commit
to alexander-beedie/polars
that referenced
this pull request
May 20, 2023
c-peters
pushed a commit
to c-peters/polars
that referenced
this pull request
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8921