Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(python): fix docstring for time() #8939

Merged
merged 1 commit into from
May 20, 2023
Merged

docs(python): fix docstring for time() #8939

merged 1 commit into from
May 20, 2023

Conversation

mcrumiller
Copy link
Contributor

Fixes #8938.

alexander-beedie
alexander-beedie approved these changes May 20, 2023
View reviewed changes
Copy link
Collaborator

@alexander-beedie alexander-beedie left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shame on me (this was my typo, hah 😅)

One minor note - try to use conventional commit prefixes for PRs, eg:
docs(python), fix(rust), feat(python,rust), etc.

@alexander-beedie alexander-beedie changed the title Fix docstring for time() docs(python): fix docstring for time() May 20, 2023
@alexander-beedie alexander-beedie added the documentation Improvements or additions to documentation label May 20, 2023
@github-actions github-actions bot added the python Related to Python Polars label May 20, 2023
@alexander-beedie alexander-beedie merged commit 0f4e932 into pola-rs:main May 20, 2023
11 checks passed
alexander-beedie pushed a commit to alexander-beedie/polars that referenced this pull request May 20, 2023
@mcrumiller @alexander-beedie
docs(python): fix docstring for time() (pola-rs#8939)
945f2c8
@mcrumiller mcrumiller deleted the time-doc-fix branch May 20, 2023 16:47
c-peters pushed a commit to c-peters/polars that referenced this pull request Jul 14, 2023
@mcrumiller @c-peters
docs(python): fix docstring for time() (pola-rs#8939)
00fa94f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-beedie alexander-beedie alexander-beedie approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docstring for pl.time says "Date" instead of "Time"
2 participants
@mcrumiller @alexander-beedie