feat(python): Add dtype
argument for repeat
#8946
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8771
Not sure this is the right way to go, since we're now casting after the
repeat
call. But then again, this is also howSeries.repeat
was already implemented, and also similar tolit(dtype=...)
.In the issue, @ritchie46 you mentioned to "cast the anyvalue before you expand", but I'm not sure how that would work.
I also made
repeat(name=...)
work for expressions; no reason it shouldn't.As a side note, I don't see the point of the
n
argument supportingExpr
input - it creates the expectation that the following will somehow work, but it doesn't:Results in:
Apparently only the very first value of the expression is considered? This is unexpected.