refactor(python): Deprecate name argument for repeat
#8977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
python
MarcoGorelli
approved these changes
May 22, 2023
There was a problem hiding this comment.
Right, so name was added to zeros and ones in #8963, not yet released, so OK to remove right away
For repeat, you're adding a deprecationwarning
For both, changing the default name without warning (sounds fine tbh)
Also, you're refacatoring repeat so the dtype is done in rust within repeat_lazy, rathern then on the Python side
Looks good to me!
|
Thanks for the review! Time to clean up some tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8972
Changes:
nameargument fromonesandzeros(these weren't released yet). Add default namezeros/ones.nameargument forrepeat. Change default name torepeat.