Skip to content

Commit

Permalink
remove memory_map arg from read_/scan_ipc() [skip ci]
Browse files Browse the repository at this point in the history
  • Loading branch information
etiennebacher committed May 24, 2024
1 parent 1d212f8 commit a5269eb
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 25 deletions.
11 changes: 2 additions & 9 deletions R/io_ipc.R
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@
#' Hive-style partitioning is not supported yet.
#' @inherit pl_scan_csv return
#' @inheritParams pl_scan_parquet
#' @param memory_map A logical. If `TRUE`, try to memory map the file.
#' This can greatly improve performance on repeated queries as the OS may cache pages.
#' Only uncompressed Arrow IPC files can be memory mapped.
#' @rdname IO_scan_ipc
#' @examplesIf requireNamespace("arrow", quietly = TRUE) && arrow::arrow_with_dataset()
#' temp_dir = tempfile()
Expand All @@ -32,7 +29,6 @@ pl_scan_ipc = function(
source,
...,
n_rows = NULL,
memory_map = TRUE,
row_index_name = NULL,
row_index_offset = 0L,
rechunk = FALSE,
Expand All @@ -43,8 +39,7 @@ pl_scan_ipc = function(
cache,
rechunk,
row_index_name,
row_index_offset,
memory_map
row_index_offset
) |>
unwrap("in pl$scan_ipc():")
}
Expand Down Expand Up @@ -89,7 +84,6 @@ pl_read_ipc = function(
source,
...,
n_rows = NULL,
memory_map = TRUE,
row_index_name = NULL,
row_index_offset = 0L,
rechunk = FALSE,
Expand All @@ -101,8 +95,7 @@ pl_read_ipc = function(
source,
n_rows,
row_index_name,
row_index_offset,
memory_map
row_index_offset
) |>
uw()
} else {
Expand Down
17 changes: 16 additions & 1 deletion man/Expr_bottom_k.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions man/IO_read_ipc.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions man/IO_scan_ipc.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 1 addition & 5 deletions tests/testthat/_snaps/lazy_profile.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@
cat(pl$LazyFrame(a = 1, b = "a")$to_dot())
Output
graph polars_query {
"[TABLE
π */2;
σ -]"
p1[label="TABLE\nπ */2;\nσ None"]
}

0 comments on commit a5269eb

Please sign in to comment.