Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build with Rust stable toolchain #276

Closed
eitsupi opened this issue Jun 29, 2023 · 3 comments · Fixed by #278
Closed

Can't build with Rust stable toolchain #276

eitsupi opened this issue Jun 29, 2023 · 3 comments · Fixed by #278
Labels
bug Something isn't working

Comments

@eitsupi
Copy link
Collaborator

eitsupi commented Jun 29, 2023

The changes made by #233 prevent builds except for nightly-toolchain.
https://github.com/pola-rs/r-polars/actions/runs/5411224946/jobs/9833719506?pr=274

Can we revert this change for now? Or Could you fix that error?

Originally posted by @eitsupi in #80 (comment)

@eitsupi eitsupi added the bug Something isn't working label Jun 29, 2023
@eitsupi eitsupi added this to the 1st CRAN Release milestone Jun 29, 2023
@sorhawell
Copy link
Collaborator

sorhawell commented Jun 29, 2023

@Sicheng-Pan @eitsupi
Sorry that is a blunder from my side, I overlooked PR used an unstable feature.

I think there is tag to forbid the compiler to use unstable features.

I will make a dumb hotfix for now.

@Sicheng-Pan maybe you can find another way to bubble the various errors.

@Sicheng-Pan
Copy link
Collaborator

@sorhawell Yeah I should have avoided using nightly features. I checked your PR and it looks good to me.

@eitsupi eitsupi linked a pull request Jun 30, 2023 that will close this issue
@eitsupi
Copy link
Collaborator Author

eitsupi commented Jun 30, 2023

Thanks for taking a look at this right away!
I think it is definitely necessary to test the build on CI with the stable toolchains. (#274)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants