Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trait specialization replace with two plain funcs #278

Merged
merged 1 commit into from
Jun 30, 2023
Merged

trait specialization replace with two plain funcs #278

merged 1 commit into from
Jun 30, 2023

Conversation

sorhawell
Copy link
Collaborator

hotfix #276

@sorhawell sorhawell marked this pull request as ready for review June 29, 2023 14:12
@sorhawell
Copy link
Collaborator Author

@eitsupi if no errors this hotfix should solve #276

@Sicheng-Pan Sicheng-Pan self-requested a review June 29, 2023 23:53
Sicheng-Pan
Sicheng-Pan approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@Sicheng-Pan Sicheng-Pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we are using some custom functions to convert Extendr and Polars errors into ours. I believe this approach is good enough for now as currently there are not too many places where we need to do the manual conversion.

@eitsupi eitsupi linked an issue Jun 30, 2023 that may be closed by this pull request
Can't build with Rust stable toolchain #276
Closed
@eitsupi
Copy link
Collaborator

eitsupi commented Jun 30, 2023

Thanks both!

@eitsupi eitsupi merged commit 5fe587b into main Jun 30, 2023
@eitsupi eitsupi deleted the try_remove_min_specialization branch June 30, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sicheng-Pan Sicheng-Pan Sicheng-Pan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't build with Rust stable toolchain
3 participants
@sorhawell @eitsupi @Sicheng-Pan