Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support Rust 1.65 #280

Merged
merged 10 commits into from
Jul 2, 2023
Merged

fix: support Rust 1.65 #280

merged 10 commits into from
Jul 2, 2023

Conversation

sorhawell
Copy link
Collaborator

@sorhawell sorhawell commented Jun 30, 2023

Fix #208

@sorhawell
Copy link
Collaborator Author

@eitsupi not sure whylinker cant find rpolars.a, but it does compile on 1.65.0 on my machine if RPOLARS_ALL_FEATURES != 'true

@eitsupi
Copy link
Collaborator

eitsupi commented Jun 30, 2023

Nice! It seems passing the MSRV check.

@sorhawell
Copy link
Collaborator Author

Nice! It seems passing the MSRV check.

changing cargo-toml from 1.66 to 1.65 now it should be more impressive :)

@eitsupi
Copy link
Collaborator

eitsupi commented Jun 30, 2023

changing cargo-toml from 1.66 to 1.65 now it should be more impressive :)

Thanks, it seems passing!

@eitsupi
Copy link
Collaborator

eitsupi commented Jul 1, 2023

The output for each profile will be placed in a directory of the same name as the profile in the target directory. As in the example above, the output would go into the target/release-lto directory.

https://doc.rust-lang.org/cargo/reference/profiles.html#custom-profiles

@eitsupi
Copy link
Collaborator

eitsupi commented Jul 1, 2023

Given the need to make significant changes to Makevars if adding profile.release-optimized, I suspect that simply setting profile.release.package.argminmax is sufficient.

I believe Makevars can be configured to change profiles via environment variables.

@eitsupi eitsupi added this to the 1st CRAN Release milestone Jul 1, 2023
@eitsupi eitsupi changed the title DO NO MERGE: set rust-version to 1.65.0 fix: set rust-version to 1.65.0 Jul 1, 2023
@eitsupi eitsupi changed the title fix: set rust-version to 1.65.0 fix: support Rust 1.65 Jul 1, 2023
@eitsupi eitsupi changed the title fix: support Rust 1.65 fix: support Rust 1.64 Jul 1, 2023
@eitsupi eitsupi changed the title fix: support Rust 1.64 fix: support Rust 1.65 Jul 1, 2023
Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be merged now.

@eitsupi eitsupi mentioned this pull request Jul 1, 2023
@eitsupi
Copy link
Collaborator

eitsupi commented Jul 2, 2023

@sorhawell Can I merge this and go ahead?

@eitsupi eitsupi marked this pull request as ready for review July 2, 2023 07:28
@sorhawell
Copy link
Collaborator Author

Ohh profile changes output dir, that was what I was missing . Thanks @eitsupi , looks good!

@sorhawell sorhawell merged commit 05690d5 into main Jul 2, 2023
11 checks passed
@sorhawell sorhawell deleted the try_build_1_65 branch July 2, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R-universe r-polars build fails because rust-polars is no longer backwards compatible with rustc 1.65.0 stable
2 participants