Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "never" in quote_style #483

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Add "never" in quote_style #483

merged 5 commits into from
Nov 9, 2023

Conversation

etiennebacher
Copy link
Collaborator

No description provided.

@etiennebacher
Copy link
Collaborator Author

@eitsupi there are some failures here with pre-built binaries but I don't understand why

Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some failures here with pre-built binaries but I don't understand why

This is caused by incompatibility with pre-built binaries.
Please increment the library version in Cargo.toml and execute make all to update the files.

tests/testthat/test-sink_stream.R Show resolved Hide resolved
src/rust/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@etiennebacher etiennebacher merged commit 5aa0603 into main Nov 9, 2023
23 checks passed
@etiennebacher etiennebacher deleted the write-csv-never-quote branch November 9, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants