Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "never" in quote_style #483

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Add "never" in quote_style #483

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c6aa51e
add "never" in quote_style
etiennebacher Nov 9, 2023
ff29879
bump news
etiennebacher Nov 9, 2023
f8a7ebc
bump r-polars rust version, use parametric tests
etiennebacher Nov 9, 2023
51ff62a
0.35.0 -> 0.34.1
etiennebacher Nov 9, 2023
6d37447
Merge branch 'main' into write-csv-never-quote
etiennebacher Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# polars (development version)

## What's changed

- The argument `quote_style` in `$write_csv()` and `$sink_csv()` can now take
the value `"never"` (#483).

# polars 0.10.0

## BREAKING CHANGES DUE TO RUST-POLARS UPDATE
Expand Down
8 changes: 3 additions & 5 deletions R/dataframe__frame.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1749,11 +1749,9 @@ DataFrame_transpose = function(
#' * `"non_numeric"`: This puts quotes around all fields that are non-numeric.
#' Namely, when writing a field that does not parse as a valid float or integer,
#' then quotes will be used even if they aren`t strictly necessary.

# TODO: include "never" when bumping rust-polars to 0.34
# * `"never"`: This never puts quotes around fields, even if that results in
# invalid CSV data (e.g.: by not quoting strings containing the separator).

#' * `"never"`: This never puts quotes around fields, even if that results in
#' invalid CSV data (e.g. by not quoting strings containing the separator).
#'
#' @return
#' This doesn't return anything but creates a CSV file.
#'
Expand Down
2 changes: 2 additions & 0 deletions man/IO_sink_csv.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions man/IO_write_csv.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions src/rust/src/utils/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,10 +588,9 @@ pub fn robj_to_quote_style(robj: Robj) -> RResult<pl::QuoteStyle> {
"always" => Ok(pl::QuoteStyle::Always),
"necessary" => Ok(pl::QuoteStyle::Necessary),
"non_numeric" => Ok(pl::QuoteStyle::NonNumeric),
// "never" is available in rust-polars devel only for now (will be added in 0.34)
// "never" => Ok(QuoteStyle::Never),
"never" => Ok(pl::QuoteStyle::Never),
_ => rerr()
.plain("a `quote_style` must be 'always', 'necessary' or 'non_numeric'.")
.plain("`quote_style` should be one of 'always', 'necessary', 'non_numeric', or 'never'.")
.bad_robj(&robj),
}
}
Expand Down
301 changes: 13 additions & 288 deletions tests/testthat/_snaps/csv-write.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,150 +54,6 @@
+4.6+,+3.1+,+1.5+,+0.2+,+setosa+
+5.0+,+3.6+,+1.4+,+0.2+,+setosa+
+5.4+,+3.9+,+1.7+,+0.4+,+setosa+
+4.6+,+3.4+,+1.4+,+0.3+,+setosa+
+5.0+,+3.4+,+1.5+,+0.2+,+setosa+
+4.4+,+2.9+,+1.4+,+0.2+,+setosa+
+4.9+,+3.1+,+1.5+,+0.1+,+setosa+
+5.4+,+3.7+,+1.5+,+0.2+,+setosa+
+4.8+,+3.4+,+1.6+,+0.2+,+setosa+
+4.8+,+3.0+,+1.4+,+0.1+,+setosa+
+4.3+,+3.0+,+1.1+,+0.1+,+setosa+
+5.8+,+4.0+,+1.2+,+0.2+,+setosa+
+5.7+,+4.4+,+1.5+,+0.4+,+setosa+
+5.4+,+3.9+,+1.3+,+0.4+,+setosa+
+5.1+,+3.5+,+1.4+,+0.3+,+setosa+
+5.7+,+3.8+,+1.7+,+0.3+,+setosa+
+5.1+,+3.8+,+1.5+,+0.3+,+setosa+
+5.4+,+3.4+,+1.7+,+0.2+,+setosa+
+5.1+,+3.7+,+1.5+,+0.4+,+setosa+
+4.6+,+3.6+,+1.0+,+0.2+,+setosa+
+5.1+,+3.3+,+1.7+,+0.5+,+setosa+
+4.8+,+3.4+,+1.9+,+0.2+,+setosa+
+5.0+,+3.0+,+1.6+,+0.2+,+setosa+
+5.0+,+3.4+,+1.6+,+0.4+,+setosa+
+5.2+,+3.5+,+1.5+,+0.2+,+setosa+
+5.2+,+3.4+,+1.4+,+0.2+,+setosa+
+4.7+,+3.2+,+1.6+,+0.2+,+setosa+
+4.8+,+3.1+,+1.6+,+0.2+,+setosa+
+5.4+,+3.4+,+1.5+,+0.4+,+setosa+
+5.2+,+4.1+,+1.5+,+0.1+,+setosa+
+5.5+,+4.2+,+1.4+,+0.2+,+setosa+
+4.9+,+3.1+,+1.5+,+0.2+,+setosa+
+5.0+,+3.2+,+1.2+,+0.2+,+setosa+
+5.5+,+3.5+,+1.3+,+0.2+,+setosa+
+4.9+,+3.6+,+1.4+,+0.1+,+setosa+
+4.4+,+3.0+,+1.3+,+0.2+,+setosa+
+5.1+,+3.4+,+1.5+,+0.2+,+setosa+
+5.0+,+3.5+,+1.3+,+0.3+,+setosa+
+4.5+,+2.3+,+1.3+,+0.3+,+setosa+
+4.4+,+3.2+,+1.3+,+0.2+,+setosa+
+5.0+,+3.5+,+1.6+,+0.6+,+setosa+
+5.1+,+3.8+,+1.9+,+0.4+,+setosa+
+4.8+,+3.0+,+1.4+,+0.3+,+setosa+
+5.1+,+3.8+,+1.6+,+0.2+,+setosa+
+4.6+,+3.2+,+1.4+,+0.2+,+setosa+
+5.3+,+3.7+,+1.5+,+0.2+,+setosa+
+5.0+,+3.3+,+1.4+,+0.2+,+setosa+
+7.0+,+3.2+,+4.7+,+1.4+,+versicolor+
+6.4+,+3.2+,+4.5+,+1.5+,+versicolor+
+6.9+,+3.1+,+4.9+,+1.5+,+versicolor+
+5.5+,+2.3+,+4.0+,+1.3+,+versicolor+
+6.5+,+2.8+,+4.6+,+1.5+,+versicolor+
+5.7+,+2.8+,+4.5+,+1.3+,+versicolor+
+6.3+,+3.3+,+4.7+,+1.6+,+versicolor+
+4.9+,+2.4+,+3.3+,+1.0+,+versicolor+
+6.6+,+2.9+,+4.6+,+1.3+,+versicolor+
+5.2+,+2.7+,+3.9+,+1.4+,+versicolor+
+5.0+,+2.0+,+3.5+,+1.0+,+versicolor+
+5.9+,+3.0+,+4.2+,+1.5+,+versicolor+
+6.0+,+2.2+,+4.0+,+1.0+,+versicolor+
+6.1+,+2.9+,+4.7+,+1.4+,+versicolor+
+5.6+,+2.9+,+3.6+,+1.3+,+versicolor+
+6.7+,+3.1+,+4.4+,+1.4+,+versicolor+
+5.6+,+3.0+,+4.5+,+1.5+,+versicolor+
+5.8+,+2.7+,+4.1+,+1.0+,+versicolor+
+6.2+,+2.2+,+4.5+,+1.5+,+versicolor+
+5.6+,+2.5+,+3.9+,+1.1+,+versicolor+
+5.9+,+3.2+,+4.8+,+1.8+,+versicolor+
+6.1+,+2.8+,+4.0+,+1.3+,+versicolor+
+6.3+,+2.5+,+4.9+,+1.5+,+versicolor+
+6.1+,+2.8+,+4.7+,+1.2+,+versicolor+
+6.4+,+2.9+,+4.3+,+1.3+,+versicolor+
+6.6+,+3.0+,+4.4+,+1.4+,+versicolor+
+6.8+,+2.8+,+4.8+,+1.4+,+versicolor+
+6.7+,+3.0+,+5.0+,+1.7+,+versicolor+
+6.0+,+2.9+,+4.5+,+1.5+,+versicolor+
+5.7+,+2.6+,+3.5+,+1.0+,+versicolor+
+5.5+,+2.4+,+3.8+,+1.1+,+versicolor+
+5.5+,+2.4+,+3.7+,+1.0+,+versicolor+
+5.8+,+2.7+,+3.9+,+1.2+,+versicolor+
+6.0+,+2.7+,+5.1+,+1.6+,+versicolor+
+5.4+,+3.0+,+4.5+,+1.5+,+versicolor+
+6.0+,+3.4+,+4.5+,+1.6+,+versicolor+
+6.7+,+3.1+,+4.7+,+1.5+,+versicolor+
+6.3+,+2.3+,+4.4+,+1.3+,+versicolor+
+5.6+,+3.0+,+4.1+,+1.3+,+versicolor+
+5.5+,+2.5+,+4.0+,+1.3+,+versicolor+
+5.5+,+2.6+,+4.4+,+1.2+,+versicolor+
+6.1+,+3.0+,+4.6+,+1.4+,+versicolor+
+5.8+,+2.6+,+4.0+,+1.2+,+versicolor+
+5.0+,+2.3+,+3.3+,+1.0+,+versicolor+
+5.6+,+2.7+,+4.2+,+1.3+,+versicolor+
+5.7+,+3.0+,+4.2+,+1.2+,+versicolor+
+5.7+,+2.9+,+4.2+,+1.3+,+versicolor+
+6.2+,+2.9+,+4.3+,+1.3+,+versicolor+
+5.1+,+2.5+,+3.0+,+1.1+,+versicolor+
+5.7+,+2.8+,+4.1+,+1.3+,+versicolor+
+6.3+,+3.3+,+6.0+,+2.5+,+virginica+
+5.8+,+2.7+,+5.1+,+1.9+,+virginica+
+7.1+,+3.0+,+5.9+,+2.1+,+virginica+
+6.3+,+2.9+,+5.6+,+1.8+,+virginica+
+6.5+,+3.0+,+5.8+,+2.2+,+virginica+
+7.6+,+3.0+,+6.6+,+2.1+,+virginica+
+4.9+,+2.5+,+4.5+,+1.7+,+virginica+
+7.3+,+2.9+,+6.3+,+1.8+,+virginica+
+6.7+,+2.5+,+5.8+,+1.8+,+virginica+
+7.2+,+3.6+,+6.1+,+2.5+,+virginica+
+6.5+,+3.2+,+5.1+,+2.0+,+virginica+
+6.4+,+2.7+,+5.3+,+1.9+,+virginica+
+6.8+,+3.0+,+5.5+,+2.1+,+virginica+
+5.7+,+2.5+,+5.0+,+2.0+,+virginica+
+5.8+,+2.8+,+5.1+,+2.4+,+virginica+
+6.4+,+3.2+,+5.3+,+2.3+,+virginica+
+6.5+,+3.0+,+5.5+,+1.8+,+virginica+
+7.7+,+3.8+,+6.7+,+2.2+,+virginica+
+7.7+,+2.6+,+6.9+,+2.3+,+virginica+
+6.0+,+2.2+,+5.0+,+1.5+,+virginica+
+6.9+,+3.2+,+5.7+,+2.3+,+virginica+
+5.6+,+2.8+,+4.9+,+2.0+,+virginica+
+7.7+,+2.8+,+6.7+,+2.0+,+virginica+
+6.3+,+2.7+,+4.9+,+1.8+,+virginica+
+6.7+,+3.3+,+5.7+,+2.1+,+virginica+
+7.2+,+3.2+,+6.0+,+1.8+,+virginica+
+6.2+,+2.8+,+4.8+,+1.8+,+virginica+
+6.1+,+3.0+,+4.9+,+1.8+,+virginica+
+6.4+,+2.8+,+5.6+,+2.1+,+virginica+
+7.2+,+3.0+,+5.8+,+1.6+,+virginica+
+7.4+,+2.8+,+6.1+,+1.9+,+virginica+
+7.9+,+3.8+,+6.4+,+2.0+,+virginica+
+6.4+,+2.8+,+5.6+,+2.2+,+virginica+
+6.3+,+2.8+,+5.1+,+1.5+,+virginica+
+6.1+,+2.6+,+5.6+,+1.4+,+virginica+
+7.7+,+3.0+,+6.1+,+2.3+,+virginica+
+6.3+,+3.4+,+5.6+,+2.4+,+virginica+
+6.4+,+3.1+,+5.5+,+1.8+,+virginica+
+6.0+,+3.0+,+4.8+,+1.8+,+virginica+
+6.9+,+3.1+,+5.4+,+2.1+,+virginica+
+6.7+,+3.1+,+5.6+,+2.4+,+virginica+
+6.9+,+3.1+,+5.1+,+2.3+,+virginica+
+5.8+,+2.7+,+5.1+,+1.9+,+virginica+
+6.8+,+3.2+,+5.9+,+2.3+,+virginica+
+6.7+,+3.3+,+5.7+,+2.5+,+virginica+
+6.7+,+3.0+,+5.2+,+2.3+,+virginica+
+6.3+,+2.5+,+5.0+,+1.9+,+virginica+
+6.5+,+3.0+,+5.2+,+2.0+,+virginica+
+6.2+,+3.4+,+5.4+,+2.3+,+virginica+
+5.9+,+3.0+,+5.1+,+1.8+,+virginica+

---

Expand All @@ -211,150 +67,19 @@
4.6,3.1,1.5,0.2,+setosa+
5.0,3.6,1.4,0.2,+setosa+
5.4,3.9,1.7,0.4,+setosa+
4.6,3.4,1.4,0.3,+setosa+
5.0,3.4,1.5,0.2,+setosa+
4.4,2.9,1.4,0.2,+setosa+
4.9,3.1,1.5,0.1,+setosa+
5.4,3.7,1.5,0.2,+setosa+
4.8,3.4,1.6,0.2,+setosa+
4.8,3.0,1.4,0.1,+setosa+
4.3,3.0,1.1,0.1,+setosa+
5.8,4.0,1.2,0.2,+setosa+
5.7,4.4,1.5,0.4,+setosa+
5.4,3.9,1.3,0.4,+setosa+
5.1,3.5,1.4,0.3,+setosa+
5.7,3.8,1.7,0.3,+setosa+
5.1,3.8,1.5,0.3,+setosa+
5.4,3.4,1.7,0.2,+setosa+
5.1,3.7,1.5,0.4,+setosa+
4.6,3.6,1.0,0.2,+setosa+
5.1,3.3,1.7,0.5,+setosa+
4.8,3.4,1.9,0.2,+setosa+
5.0,3.0,1.6,0.2,+setosa+
5.0,3.4,1.6,0.4,+setosa+
5.2,3.5,1.5,0.2,+setosa+
5.2,3.4,1.4,0.2,+setosa+
4.7,3.2,1.6,0.2,+setosa+
4.8,3.1,1.6,0.2,+setosa+
5.4,3.4,1.5,0.4,+setosa+
5.2,4.1,1.5,0.1,+setosa+
5.5,4.2,1.4,0.2,+setosa+
4.9,3.1,1.5,0.2,+setosa+
5.0,3.2,1.2,0.2,+setosa+
5.5,3.5,1.3,0.2,+setosa+
4.9,3.6,1.4,0.1,+setosa+
4.4,3.0,1.3,0.2,+setosa+
5.1,3.4,1.5,0.2,+setosa+
5.0,3.5,1.3,0.3,+setosa+
4.5,2.3,1.3,0.3,+setosa+
4.4,3.2,1.3,0.2,+setosa+
5.0,3.5,1.6,0.6,+setosa+
5.1,3.8,1.9,0.4,+setosa+
4.8,3.0,1.4,0.3,+setosa+
5.1,3.8,1.6,0.2,+setosa+
4.6,3.2,1.4,0.2,+setosa+
5.3,3.7,1.5,0.2,+setosa+
5.0,3.3,1.4,0.2,+setosa+
7.0,3.2,4.7,1.4,+versicolor+
6.4,3.2,4.5,1.5,+versicolor+
6.9,3.1,4.9,1.5,+versicolor+
5.5,2.3,4.0,1.3,+versicolor+
6.5,2.8,4.6,1.5,+versicolor+
5.7,2.8,4.5,1.3,+versicolor+
6.3,3.3,4.7,1.6,+versicolor+
4.9,2.4,3.3,1.0,+versicolor+
6.6,2.9,4.6,1.3,+versicolor+
5.2,2.7,3.9,1.4,+versicolor+
5.0,2.0,3.5,1.0,+versicolor+
5.9,3.0,4.2,1.5,+versicolor+
6.0,2.2,4.0,1.0,+versicolor+
6.1,2.9,4.7,1.4,+versicolor+
5.6,2.9,3.6,1.3,+versicolor+
6.7,3.1,4.4,1.4,+versicolor+
5.6,3.0,4.5,1.5,+versicolor+
5.8,2.7,4.1,1.0,+versicolor+
6.2,2.2,4.5,1.5,+versicolor+
5.6,2.5,3.9,1.1,+versicolor+
5.9,3.2,4.8,1.8,+versicolor+
6.1,2.8,4.0,1.3,+versicolor+
6.3,2.5,4.9,1.5,+versicolor+
6.1,2.8,4.7,1.2,+versicolor+
6.4,2.9,4.3,1.3,+versicolor+
6.6,3.0,4.4,1.4,+versicolor+
6.8,2.8,4.8,1.4,+versicolor+
6.7,3.0,5.0,1.7,+versicolor+
6.0,2.9,4.5,1.5,+versicolor+
5.7,2.6,3.5,1.0,+versicolor+
5.5,2.4,3.8,1.1,+versicolor+
5.5,2.4,3.7,1.0,+versicolor+
5.8,2.7,3.9,1.2,+versicolor+
6.0,2.7,5.1,1.6,+versicolor+
5.4,3.0,4.5,1.5,+versicolor+
6.0,3.4,4.5,1.6,+versicolor+
6.7,3.1,4.7,1.5,+versicolor+
6.3,2.3,4.4,1.3,+versicolor+
5.6,3.0,4.1,1.3,+versicolor+
5.5,2.5,4.0,1.3,+versicolor+
5.5,2.6,4.4,1.2,+versicolor+
6.1,3.0,4.6,1.4,+versicolor+
5.8,2.6,4.0,1.2,+versicolor+
5.0,2.3,3.3,1.0,+versicolor+
5.6,2.7,4.2,1.3,+versicolor+
5.7,3.0,4.2,1.2,+versicolor+
5.7,2.9,4.2,1.3,+versicolor+
6.2,2.9,4.3,1.3,+versicolor+
5.1,2.5,3.0,1.1,+versicolor+
5.7,2.8,4.1,1.3,+versicolor+
6.3,3.3,6.0,2.5,+virginica+
5.8,2.7,5.1,1.9,+virginica+
7.1,3.0,5.9,2.1,+virginica+
6.3,2.9,5.6,1.8,+virginica+
6.5,3.0,5.8,2.2,+virginica+
7.6,3.0,6.6,2.1,+virginica+
4.9,2.5,4.5,1.7,+virginica+
7.3,2.9,6.3,1.8,+virginica+
6.7,2.5,5.8,1.8,+virginica+
7.2,3.6,6.1,2.5,+virginica+
6.5,3.2,5.1,2.0,+virginica+
6.4,2.7,5.3,1.9,+virginica+
6.8,3.0,5.5,2.1,+virginica+
5.7,2.5,5.0,2.0,+virginica+
5.8,2.8,5.1,2.4,+virginica+
6.4,3.2,5.3,2.3,+virginica+
6.5,3.0,5.5,1.8,+virginica+
7.7,3.8,6.7,2.2,+virginica+
7.7,2.6,6.9,2.3,+virginica+
6.0,2.2,5.0,1.5,+virginica+
6.9,3.2,5.7,2.3,+virginica+
5.6,2.8,4.9,2.0,+virginica+
7.7,2.8,6.7,2.0,+virginica+
6.3,2.7,4.9,1.8,+virginica+
6.7,3.3,5.7,2.1,+virginica+
7.2,3.2,6.0,1.8,+virginica+
6.2,2.8,4.8,1.8,+virginica+
6.1,3.0,4.9,1.8,+virginica+
6.4,2.8,5.6,2.1,+virginica+
7.2,3.0,5.8,1.6,+virginica+
7.4,2.8,6.1,1.9,+virginica+
7.9,3.8,6.4,2.0,+virginica+
6.4,2.8,5.6,2.2,+virginica+
6.3,2.8,5.1,1.5,+virginica+
6.1,2.6,5.6,1.4,+virginica+
7.7,3.0,6.1,2.3,+virginica+
6.3,3.4,5.6,2.4,+virginica+
6.4,3.1,5.5,1.8,+virginica+
6.0,3.0,4.8,1.8,+virginica+
6.9,3.1,5.4,2.1,+virginica+
6.7,3.1,5.6,2.4,+virginica+
6.9,3.1,5.1,2.3,+virginica+
5.8,2.7,5.1,1.9,+virginica+
6.8,3.2,5.9,2.3,+virginica+
6.7,3.3,5.7,2.5,+virginica+
6.7,3.0,5.2,2.3,+virginica+
6.3,2.5,5.0,1.9,+virginica+
6.5,3.0,5.2,2.0,+virginica+
6.2,3.4,5.4,2.3,+virginica+
5.9,3.0,5.1,1.8,+virginica+

---

Code
cat(readLines(path), sep = "\n")
Output
Sepal.Length,Sepal.Width,Petal.Length,Petal.Width,Species
5.1,3.5,1.4,0.2,setosa
4.9,3.0,1.4,0.2,setosa
4.7,3.2,1.3,0.2,setosa
4.6,3.1,1.5,0.2,setosa
5.0,3.6,1.4,0.2,setosa
5.4,3.9,1.7,0.4,setosa

# write_csv: quote_style quote_style=necessary

Expand Down
Loading
Loading