Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the arr subnamespace #790

Merged
merged 23 commits into from
Feb 11, 2024
Merged

Implement the arr subnamespace #790

merged 23 commits into from
Feb 11, 2024

Conversation

etiennebacher
Copy link
Collaborator

@etiennebacher etiennebacher commented Feb 8, 2024

Close #710

Still WIP:

  • add tests
  • double-check when strings are parsed as column names and when they're not as there are some inconsistencies with the list subnamespace
  • cleanup docs (mostly for datatype)

@etiennebacher
Copy link
Collaborator Author

etiennebacher commented Feb 9, 2024

@eitsupi R CMD check fails for ubuntu/macos but not for Windows. I'm on windows for now, can you reproduce these panics on either ubuntu or macos? My bad, it fails everywhere but I still can't reproduce locally, can you try?

@eitsupi
Copy link
Collaborator

eitsupi commented Feb 10, 2024

https://github.com/pola-rs/r-polars/actions/runs/7844014358/job/21405536688?pr=790#step:11:62

   thread '<unnamed>' panicked at /home/runner/.cargo/git/checkouts/polars-b0d90607192fd414/f3c4cc5/crates/polars-arrow/src/bitmap/immutable.rs:156:24:
  range end index 2 out of range for slice of length 1

It looks like a bug in Rust itself that has not yet been fixed in the latest release. rust-lang/rust#119352

@etiennebacher
Copy link
Collaborator Author

Given this leads to panicks (and segfaults if it runs twice), we should probably remove arr$min and arr$max for now and reimplement them when rust-polars 0.38.0 is released. Do you agree?

@eitsupi
Copy link
Collaborator

eitsupi commented Feb 10, 2024

Do you agree?

Or I think it could be classified as nightly functions instead of doing a deletion.

[features]
default = []
full_features = ["simd", "sql", "disable_limit_max_threads"]
disable_limit_max_threads = []
simd = ["polars/simd"]
sql = ["polars/sql"]
rpolars_debug_print = []

This actually has nothing to do with simd, but could you make sure to check the simd feature anyway?
I would like to organize the features later (#300).

@etiennebacher
Copy link
Collaborator Author

Not sure I understood correctly, is 097da1a what you had in mind?

@eitsupi
Copy link
Collaborator

eitsupi commented Feb 10, 2024

It is a little different; it does not need to be handled on the Rust side.
Please wait a bit while I fix it.

@etiennebacher
Copy link
Collaborator Author

Thanks for the fix, I'll try to finish this PR during the weekend

@eitsupi eitsupi removed the upstream label Feb 10, 2024
@eitsupi eitsupi added this to the 0.14 milestone Feb 10, 2024
@etiennebacher etiennebacher marked this pull request as ready for review February 11, 2024 12:28
@eitsupi eitsupi merged commit 53d4aba into main Feb 11, 2024
33 checks passed
@eitsupi eitsupi deleted the implement-arr-namespace branch February 11, 2024 12:40
@eitsupi
Copy link
Collaborator

eitsupi commented Feb 11, 2024

@etiennebacher Could you update the NEWS in a follow up PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the arr subnamespace
2 participants