refactor!: feature flags reorganizization #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
changed the title
nightly instead of simdnightly instead of simd
eitsupi
changed the title
nightly instead of simd
eitsupi
changed the title
| @@ -24,6 +24,8 @@ | |||
|
|
|||
| ### Other breaking changes | |||
|
|
|||
| - The `simd` feature of the Rust library is removed in favor of | |||
There was a problem hiding this comment.
can you add details on whether it changes something for the users? Should they change anything?
There was a problem hiding this comment.
Since we can update the NEWS file later, could you approve it for now?
It contains changes to the manifest file, and given the caching and the number of jobs triggered, I don't want to prolong this PR with only a documentation update.
| @@ -51,6 +53,10 @@ | |||
| - `pl$threadpool_size()` is deprecated and will be removed in 0.15.0. Use | |||
| `pl$thread_pool_size()` instead (#784). | |||
|
|
|||
| ### Other improvements | |||
|
|
|||
| - The `sql` feature is included in the default feature (#800). | |||
etiennebacher
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #300
Match with py-polars.
polars/nightlyincludespolars/simd, and py-polars does not specifypolars/simddirectly but includespolras/nightlyin thenightlyfeature.defaultfeature includes thesqlfeature (becausesqlno longer requires nightly toolchain).