minimal changes to rename package #84

sorhawell · 2023-03-20T23:55:14Z

commit all, a few tests fail in check only, not sure why

sorhawell · 2023-03-21T07:19:13Z

A first attempt on renaming to polars #82

eitsupi · 2023-03-21T15:39:18Z

minimal changes to rename repo

Maybe "rename package"?

sorhawell · 2023-03-21T19:29:48Z

Oups :)

grantmcdermott · 2023-03-22T06:15:05Z

You've probably already noticed, but the vignette/rpolars.Rmd file will need to be changed to vignette/polars.Rmd, and then the internal refs in the same file to "(r)polars" will need to need to be changed too.

sorhawell · 2023-03-22T11:11:58Z

Small news update for all the kind contributors who read PRs :)
The next three months I have a consultancy contract and a little paternity leave. I will be working in some evenings, but things will progress slower and you might see some dangling draft PRs from my side, as this one.
However, I will try to process any Issue/request/PR within 48hours or so

grantmcdermott · 2023-03-22T15:16:57Z

Congrats! (I'm going on vacation tomorrow, so might not make the cutoff. But will see if I have anything that might get in under the wire...)

Merge branch 'main' into rename_minimal # Conflicts: # README.Rmd

Merge branch 'main' into rename_minimal # Conflicts: # README.md

Merge branch 'main' into rename_minimal # Conflicts: # README.Rmd

sorhawell · 2023-03-30T20:08:01Z

I notice r-universe-org/help#28 might result in duplicate packages (rpolars + polars) for some time on R-universe. But I guess we can take it as it comes.

grantmcdermott

A couple of thoughts and suggestions, mostly regarding documentation.

grantmcdermott · 2023-03-30T23:19:52Z

vignettes/polars.Rmd

+title: "Introduction to polars in R"
 output: rmarkdown::html_vignette
 vignette: >
-  %\VignetteIndexEntry{Introduction to rpolars}
+  %\VignetteIndexEntry{Introduction to polars in R}


Grammatically, "polars in R" sounds a bit off. Maybe change to "An Introduction to Polars from R" (or just "Polars from R").

grantmcdermott · 2023-03-30T23:20:04Z

README.Rmd

@@ -13,7 +13,7 @@ knitr::opts_chunk$set(
 )
 ```

-# rpolars
+# polars


Maybe this should be "Polars from R"? Although, if we're keeping with the arrow way of doing things then just "polars" is fine (see here)

grantmcdermott · 2023-03-30T23:28:03Z

README.Rmd

@@ -26,7 +26,7 @@ The goal of this project is to bring the blazingly fast
 computation engine is written in Rust and this R implementation has no other
 dependencies than R itself (≥ 4.1.0).

-Documentation can be found on the **rpolars**
+Documentation can be found on the **r-polars**


Perhaps personal preference but I think the link link should be to the actual index page (i.e., https://rpolars.github.io/index.html) rather than the reference manual. That way your readers are able top navigate more easily to where they want (e.g., installation section of the README/landing page or the vignette).

I will change back to entry page. It is also much prettier now, after latest release, as the main page is now your readme contribution :)

https://rpolars.github.io/

grantmcdermott · 2023-03-30T23:32:34Z

README.Rmd

 development workflow is as follows: 

-**Step 1:** Fork the **rpolars** repo on GitHub and then clone it locally.
+**Step 1:** Fork the **polars** repo on GitHub and then clone it locally.


Again, to avoid ambiguity, I would say: "..Fork the R **polars repo..."

Also: This is more to do with Step 2+ (not shown here) but is this workflow still the same even if the repo structure has changed? Aren't we using the pola-rs/rpolars/package suggested by @eitsupi? (Or did I miss something?) If so, wouldn't they at least need to cd one directory deeper, i.e. cd r-polars/package...

grantmcdermott · 2023-03-30T23:34:52Z

README.Rmd

@@ -195,10 +195,10 @@ Rust toolchain

 #### Development workflow

-Assuming the system dependencies have been met (above), the typical **rpolars**
+Assuming the system dependencies have been met (above), the typical **polars**


To avoid ambiguity, I would say: "..the typical R polars workflow..."

grantmcdermott · 2023-03-30T23:46:08Z

vignettes/polars.Rmd

-**rpolars** package provides equivalent bindings from R.
+libraries available in any language. The underlying computation engine is
+written in Rust and can be used directly from via the polars crate. Orginally Polars bindings were implemented for Python. The **polars** R-package also provides equivalent bindings from R. Within
+R, python and rust each polars package is just called polars. The implemention polars in the


Couple of typos here. I would rewrite, starting with the "Within" on the previous line:

"Note that, within each language, the relevant implementation package is just called "polars". However, for clarity we may use a prefix when referring to specific implementations (i.e., rust-polars, py-polars, r-polars, nodejs-polars, etc.)

Many thanks :) I add changes and Monday.

grantmcdermott · 2023-04-12T15:33:10Z

@sorhawell Your call at the end of the day, of course. But I think it's probably a good idea to merge this change sooner rather than later. (Assuming you're still happy with the renaming idea and all checks etc are passing.)

I noticed that the rpolars website and repo are being shared on social media, which seems to be triggering increased traffic and contributions. (Which is great!) I personally think it's better to align the structure of the repo now, before this branch diverges too much from any new contributions.

Tagging @eitsupi and @vincentarelbundock in case they have a different opinion.

vincentarelbundock · 2023-04-12T15:35:06Z

Thanks for the tag. I don't really have a view on this.

eitsupi · 2023-04-12T15:45:57Z

I too think this should be merged.

From extendr's Discord conversation, @sorhawell seems to be busy these days.
@sorhawell If you would like, I can press the merge button on this PR. How about it?

This is a breaking change and should be noted in NEWS, etc., but I don't think it needs to be included in this PR since that can be done later.

eitsupi · 2023-04-13T13:43:35Z

Ok, let's merge.

commit all, trsts fail in check only

1aeab31

sorhawell changed the title ~~minimal changes to rename repo~~ minimal changes to rename package Mar 21, 2023

sorhawell added 16 commits March 23, 2023 22:10

rpolars.rmd -> polars.rmd

f34c163

skip if no bit64 + s_u32->r_f64

1107e40

remove rpolars from readme and testthat

2aa042b

drop some rpolars in roxygen docs

6a63dc0

remove more rpolars from docs and comments

f239a77

merge in main

fd1e3d7

Merge branch 'main' into rename_minimal # Conflicts: # README.Rmd

rename linker def file rpolars-x -> polars-win.def

f2415ed

change link lib name to polars

39d7fa7

fix rename bug in win build

354a8ab

add two comments to rust toml

cba17df

rename rpolars_opt_xxx

2e198d3

rename rpolars in README

c6a5e56

rename rpolars_opt, the docs

94bb8ec

merge in main

f521fde

Merge branch 'main' into rename_minimal # Conflicts: # README.md

merge in main

ac46168

Merge branch 'main' into rename_minimal # Conflicts: # README.Rmd

more renmaing

5d6aaf9

sorhawell marked this pull request as ready for review March 30, 2023 20:08

grantmcdermott requested changes Mar 30, 2023

View reviewed changes

few more changes

fd9c5eb

eitsupi merged commit a4def14 into main Apr 13, 2023

eitsupi deleted the rename_minimal branch April 13, 2023 13:43

eitsupi mentioned this pull request Apr 13, 2023

rename the package rpolars/rpolars.r-universe.dev#1

Merged

grantmcdermott mentioned this pull request Apr 13, 2023

R-universe build missing? #110

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

minimal changes to rename package #84

minimal changes to rename package #84

sorhawell commented Mar 20, 2023

sorhawell commented Mar 21, 2023

eitsupi commented Mar 21, 2023

sorhawell commented Mar 21, 2023

grantmcdermott commented Mar 22, 2023 •

edited

Loading

sorhawell commented Mar 22, 2023

grantmcdermott commented Mar 22, 2023

sorhawell commented Mar 30, 2023 •

edited

Loading

grantmcdermott left a comment

grantmcdermott Mar 30, 2023

grantmcdermott Mar 30, 2023 •

edited

Loading

grantmcdermott Mar 30, 2023 •

edited

Loading

sorhawell Apr 5, 2023

grantmcdermott Mar 30, 2023

grantmcdermott Mar 30, 2023

grantmcdermott Mar 30, 2023 •

edited

Loading

sorhawell Mar 31, 2023

grantmcdermott commented Apr 12, 2023

vincentarelbundock commented Apr 12, 2023

eitsupi commented Apr 12, 2023

eitsupi commented Apr 13, 2023

minimal changes to rename package #84

minimal changes to rename package #84

Conversation

sorhawell commented Mar 20, 2023

sorhawell commented Mar 21, 2023

eitsupi commented Mar 21, 2023

sorhawell commented Mar 21, 2023

grantmcdermott commented Mar 22, 2023 • edited Loading

sorhawell commented Mar 22, 2023

grantmcdermott commented Mar 22, 2023

sorhawell commented Mar 30, 2023 • edited Loading

grantmcdermott left a comment

Choose a reason for hiding this comment

grantmcdermott Mar 30, 2023

Choose a reason for hiding this comment

grantmcdermott Mar 30, 2023 • edited Loading

Choose a reason for hiding this comment

grantmcdermott Mar 30, 2023 • edited Loading

Choose a reason for hiding this comment

sorhawell Apr 5, 2023

Choose a reason for hiding this comment

grantmcdermott Mar 30, 2023

Choose a reason for hiding this comment

grantmcdermott Mar 30, 2023

Choose a reason for hiding this comment

grantmcdermott Mar 30, 2023 • edited Loading

Choose a reason for hiding this comment

sorhawell Mar 31, 2023

Choose a reason for hiding this comment

grantmcdermott commented Apr 12, 2023

vincentarelbundock commented Apr 12, 2023

eitsupi commented Apr 12, 2023

eitsupi commented Apr 13, 2023

grantmcdermott commented Mar 22, 2023 •

edited

Loading

sorhawell commented Mar 30, 2023 •

edited

Loading

grantmcdermott Mar 30, 2023 •

edited

Loading

grantmcdermott Mar 30, 2023 •

edited

Loading

grantmcdermott Mar 30, 2023 •

edited

Loading