-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should package name be “polars”? #82
Comments
@grantmcdermott you're right it is a bit confusing as of now. Current naming within the polars organization are (project; package) I don't like currently writing docs and have to choose between r-polars and rpolars knowing most readers will not see the difference. What do you think of that? |
Perhaps one of the following two would be better?
Certainly the former may be more consistent. (which seems to be more common in the R package) |
Thanks both. I really like @eitsupi's first suggestion: Use repo: This would obviously be a breaking change, since the package name will be changing. But I personally think it's worth it to establish long-term consistency. (And, as @sorhawell says, make it easier to maintain docs!) P.S. I'm sure there are plenty of examples that follow the above structure. But one that comes to mind is tinytest. |
I think this can be closed via the recent PR merge, no? |
Yes, let's close. |
As a general principle, I think that repo names should correspond exactly to package names. Unfortunately, there’s a subtle hyphen in the way here, which IMO is unnecessary and potentially confusing for users who are trying to install from source.
TL;DR Consider moving the repo from
pola-rs/r-polars
topola-rs/rpolars
(i.e., drop the second hyphen).The text was updated successfully, but these errors were encountered: