Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Bump rust-polars to 0.36.2 #659

Merged
merged 18 commits into from
Jan 4, 2024
Merged

feat: Bump rust-polars to 0.36.2 #659

Changes from 2 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
81cf9dc
init [skip ci]
etiennebacher Jan 3, 2024
51dc365
feat: bump polars
eitsupi Jan 3, 2024
a8a2349
Merge branch 'eitsupi/rust-polars-0.36' into rust-polars-0.36
eitsupi Jan 3, 2024
d052375
test: update snapshot
eitsupi Jan 3, 2024
1a09ccf
fix: allow Utf8 as an alias of String
eitsupi Jan 3, 2024
248deca
test: update snapshot
eitsupi Jan 3, 2024
17dc3b2
test: update error message
eitsupi Jan 3, 2024
450f02e
test: update test for n_unique
eitsupi Jan 3, 2024
03ac58d
fix: ensure UInt32 for gather's idx argument
eitsupi Jan 3, 2024
b002970
chore: update encode/decode in R side
eitsupi Jan 3, 2024
27b264d
feat: support negative indexing in gather
eitsupi Jan 3, 2024
535b8ea
replace `pl$Utf8` by `pl$String` in docs and tests
etiennebacher Jan 3, 2024
52cd70d
bump news
etiennebacher Jan 3, 2024
c4a2e58
better news
etiennebacher Jan 3, 2024
65af6c4
docs: forgot occurrences of `pl$Utf8`
etiennebacher Jan 3, 2024
bc033cf
add a test for equivalence of `pl$String` and `pl$Utf8`
etiennebacher Jan 3, 2024
5458b01
read/scan_csv: replace keyword "Utf8" by "String"
etiennebacher Jan 3, 2024
c694e98
chore: fix version numbers
eitsupi Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/rust/src/rdatatype.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ impl RPolarsDataType {
"Float32" | "float32" | "double" => pl::DataType::Float32,
"Float64" | "float64" => pl::DataType::Float64,

"String" | "character" => pl::DataType::String,
"Utf8" | "String" | "character" => pl::DataType::String,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just getting started on this too. I think we can leave Utf8 as an alias, as py-polars does the same thing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should keep an alias but I guess docs should be updated to prefer "String" instead

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead if you want, let me know when I can jump in ;)

"Binary" | "binary" => pl::DataType::Binary,
"Date" | "date" => pl::DataType::Date,
"Time" | "time" => pl::DataType::Time,
Expand Down
Loading