Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement $sink_ndjson() #681

Merged
merged 8 commits into from
Jan 11, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### What's changed

- New method `$rolling()` for `DataFrame` and `LazyFrame` (#682).
- New method `$sink_ndjson()` for LazyFrame (#681).

## polars 0.12.2

Expand Down
2 changes: 2 additions & 0 deletions R/extendr-wrappers.R
Original file line number Diff line number Diff line change
Expand Up @@ -1033,6 +1033,8 @@ RPolarsLazyFrame$sink_ipc <- function(path, compression_method, maintain_order)

RPolarsLazyFrame$sink_csv <- function(path, include_bom, include_header, separator, line_terminator, quote, batch_size, datetime_format, date_format, time_format, float_precision, null_value, quote_style, maintain_order) .Call(wrap__RPolarsLazyFrame__sink_csv, self, path, include_bom, include_header, separator, line_terminator, quote, batch_size, datetime_format, date_format, time_format, float_precision, null_value, quote_style, maintain_order)

RPolarsLazyFrame$sink_json <- function(path, maintain_order) .Call(wrap__RPolarsLazyFrame__sink_json, self, path, maintain_order)

RPolarsLazyFrame$first <- function() .Call(wrap__RPolarsLazyFrame__first, self)

RPolarsLazyFrame$last <- function() .Call(wrap__RPolarsLazyFrame__last, self)
Expand Down
60 changes: 60 additions & 0 deletions R/lazyframe__lazy.R
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,66 @@ LazyFrame_sink_csv = function(
}


#' @title Stream the output of a query to a JSON file
#' @description
#' This writes the output of a query directly to a JSON file without collecting
#' it in the R session first. This is useful if the output of the query is still
#' larger than RAM as it would crash the R session if it was collected into R.
#'
#' @inheritParams DataFrame_write_csv
#' @inheritParams LazyFrame_collect
#' @inheritParams DataFrame_unique
#'
#' @rdname IO_sink_ndjson
#'
#' @examples
#' # sink table 'mtcars' from mem to JSON
#' tmpf = tempfile(fileext = ".json")
#' pl$LazyFrame(mtcars)$sink_ndjson(tmpf)
#'
#' # load parquet directly into a DataFrame / memory
#' pl$scan_ndjson(tmpf)$collect()
LazyFrame_sink_ndjson = function(
path,
maintain_order = TRUE,
type_coercion = TRUE,
predicate_pushdown = TRUE,
projection_pushdown = TRUE,
simplify_expression = TRUE,
slice_pushdown = TRUE,
no_optimization = FALSE,
inherit_optimization = FALSE) {
if (isTRUE(no_optimization)) {
predicate_pushdown = FALSE
projection_pushdown = FALSE
slice_pushdown = FALSE
}

lf = self

if (isFALSE(inherit_optimization)) {
lf = self$set_optimization_toggle(
type_coercion,
predicate_pushdown,
projection_pushdown,
simplify_expression,
slice_pushdown,
comm_subplan_elim = FALSE,
comm_subexpr_elim = FALSE,
streaming = FALSE
) |> unwrap("in $sink_ndjson()")
}

lf |>
.pr$LazyFrame$sink_json(
path,
maintain_order
) |>
unwrap("in $sink_ndjson()") |>
invisible()
}


#' @title Limit a LazyFrame
#' @inherit DataFrame_limit description params details
#' @return A `LazyFrame`
Expand Down
61 changes: 61 additions & 0 deletions man/IO_sink_ndjson.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions src/rust/src/lazy/dataframe.rs
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,15 @@ impl RPolarsLazyFrame {
.map_err(polars_to_rpolars_err)
}

fn sink_json(&self, path: Robj, maintain_order: Robj) -> RResult<()> {
let maintain_order = robj_to!(bool, maintain_order)?;
let options = pl::JsonWriterOptions { maintain_order };
self.0
.clone()
.sink_json(robj_to!(String, path)?.into(), options)
.map_err(polars_to_rpolars_err)
}

fn first(&self) -> Self {
self.0.clone().first().into()
}
Expand Down
28 changes: 14 additions & 14 deletions tests/testthat/_snaps/after-wrappers.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,13 +151,13 @@
[35] "select" "set_optimization_toggle"
[37] "shift" "shift_and_fill"
[39] "sink_csv" "sink_ipc"
[41] "sink_parquet" "slice"
[43] "sort" "std"
[45] "sum" "tail"
[47] "unique" "unnest"
[49] "var" "width"
[51] "with_columns" "with_context"
[53] "with_row_count"
[41] "sink_ndjson" "sink_parquet"
[43] "slice" "sort"
[45] "std" "sum"
[47] "tail" "unique"
[49] "unnest" "var"
[51] "width" "with_columns"
[53] "with_context" "with_row_count"

---

Expand All @@ -183,13 +183,13 @@
[33] "select" "select_str_as_lit"
[35] "set_optimization_toggle" "shift"
[37] "shift_and_fill" "sink_csv"
[39] "sink_ipc" "sink_parquet"
[41] "slice" "sort_by_exprs"
[43] "std" "sum"
[45] "tail" "unique"
[47] "unnest" "var"
[49] "with_columns" "with_context"
[51] "with_row_count"
[39] "sink_ipc" "sink_json"
[41] "sink_parquet" "slice"
[43] "sort_by_exprs" "std"
[45] "sum" "tail"
[47] "unique" "unnest"
[49] "var" "with_columns"
[51] "with_context" "with_row_count"

# public and private methods of each class Expr

Expand Down
21 changes: 21 additions & 0 deletions tests/testthat/_snaps/sink_stream.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,24 @@
a,b,c
"foo",1.0,a

# sink_ndjson works

Code
cat(readLines(path, warn = FALSE), sep = "\n")
Output
{"drat":3.9,"mpg":21.0}
{"drat":3.9,"mpg":21.0}
{"drat":3.85,"mpg":22.8}
{"drat":3.08,"mpg":21.4}
{"drat":3.15,"mpg":18.7}
{"drat":2.76,"mpg":18.1}
{"drat":3.21,"mpg":14.3}
{"drat":3.69,"mpg":24.4}
{"drat":3.92,"mpg":22.8}
{"drat":3.92,"mpg":19.2}
{"drat":3.92,"mpg":17.8}
{"drat":3.07,"mpg":16.4}
{"drat":3.07,"mpg":17.3}
{"drat":3.07,"mpg":15.2}
{"drat":2.93,"mpg":10.4}

9 changes: 9 additions & 0 deletions tests/testthat/test-sink_stream.R
Original file line number Diff line number Diff line change
Expand Up @@ -222,3 +222,12 @@ test_that("sink_csv: float_precision works", {
data.frame(x = c(1.234, 5.600))
)
})


# sink_ndjson ---------------------------------------------------------

test_that("sink_ndjson works", {
temp_out = tempfile(fileext = ".json")
pl$LazyFrame(mtcars)$head(15)$select(pl$col("drat", "mpg"))$sink_ndjson(temp_out)
expect_snapshot_file(temp_out)
})
Loading