-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align arguments of several string to date(time) functions with python polars #939
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but honestly, I feel that checking dots is overkill here.
(If we do it, wouldn't it be better to import rlang
and use check_dots_empty
etc to simplify things?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once again, on second thought, I disagree with the idea of doing a dots check process for variable name changes.
There are currently so many variable mismatches with Rust/Python Polars in this package that I don't want to take on the huge amount of work involved in writing and later removing all those checks.
It would be better to get the variable name fixes done as quickly as possible than to expend the effort on such a thing.
True but then I think we should advertise more in the README that the package is unstable and that naming all args is a good practice to reduce breaking changes. I'll remove those checks |
I think that makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
One minor comment.
No description provided.