fix: pass join_nulls and validate to the lazy method for $join()
#949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
george-wood
changed the title
join_nulls and validate to the lazy method for $join()$join_nulls and validate to the lazy method for $join()
There was a problem hiding this comment.
Thanks @george-wood, that looks good to me. Can you also add tests for the arg
validate for DataFrame?
I think the CI failure is unrelated
eitsupi
reviewed
Mar 20, 2024
Add tests for the `validate` argument for DataFrame joins
eitsupi
requested changes
Mar 21, 2024
eitsupi
approved these changes
Mar 21, 2024
eitsupi
reviewed
Mar 21, 2024
Co-authored-by: eitsupi <50911393+eitsupi@users.noreply.github.com>
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #945.