Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pl$mean_horizontal() function #959

Merged
merged 6 commits into from
Mar 22, 2024

Conversation

george-wood
Copy link
Contributor

Proposed in #854.

@george-wood
Copy link
Contributor Author

george-wood commented Mar 22, 2024

  • I reverted a few changes to unrelated Rd files.
  • I also added pl$mean_horizontal() to the seealso of pl$mean() and removed the related TODO.
  • I ran task test-snapshot-accept following the R CMD failure.

Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I have updated the Rd files and test snapshots.

@eitsupi eitsupi merged commit f239cd6 into pola-rs:main Mar 22, 2024
35 checks passed
@etiennebacher
Copy link
Collaborator

Nice, thank you @george-wood 👍

There were a couple of minor things to improve in the docs, see the followup here: #960

@george-wood
Copy link
Contributor Author

@etiennebacher Good improvements. I used NaN and -Inf in the tests, but not the examples. It's good to clearly show this behavior (especially for NaN/null) in #960.

@george-wood george-wood deleted the mean_horizontal branch March 22, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants