refactor!: rewrite str$contains()
#982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etiennebacher
approved these changes
Mar 29, 2024
R/expr__string.R
Outdated
Comment on lines
451
to
455
| #' # The inline `(?i)` syntax example | ||
| #' pl$DataFrame(s = c("AAA", "aAa", "aaa"))$with_columns( | ||
| #' default_match = pl$col("s")$str$contains("AA"), | ||
| #' insensitive_match = pl$col("s")$str$contains("(?i)AA") | ||
| #' ) |
There was a problem hiding this comment.
Nice to showcase this
src/rust/src/lazy/dsl.rs
Outdated
| Some(true) => self.0.clone().str().contains_literal(pat.0.clone()), | ||
| _ => self.0.clone().str().contains(pat.0.clone(), strict), | ||
| }) | ||
| pub fn str_contains(&self, pat: &RPolarsExpr, literal: Robj, strict: Robj) -> RResult<Self> { |
There was a problem hiding this comment.
Shouldn't pat be Robj here? I think that would remove the need for .0.clone() below
There was a problem hiding this comment.
Good point.
The conversion to Expr on the Rust side was shown to be sufficient and conversion on the R side was found to be unnecessary.
Merged
Co-authored-by: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.