implement <Series>$n_chunks() method
#999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
requested changes
Mar 31, 2024
There was a problem hiding this comment.
Thanks for your contribution!
I think they should return an integer, but they may be set to return a double since there is no int64 type in R.
Please complete the roxygen comment and generate the Rd file.
See https://github.com/pola-rs/r-polars/blob/main/DEVELOPMENT.md
eitsupi
changed the title
n_chunks method<Series>$n_chunks() method
eitsupi
requested changes
Mar 31, 2024
eitsupi
requested changes
Mar 31, 2024
eitsupi
requested changes
Mar 31, 2024
eitsupi
approved these changes
Mar 31, 2024
Sorry, I missed this message :) . Great appreciate for your review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One issue is the returned type, I have seen
Pythonuse integer, but I observed$len()method return a numeric. Is there any reason to return numeric? For R function length, they all have a integer mode