Skip to content

Commit

Permalink
Merge pull request spring-projects#11779 from rajadilipkolli
Browse files Browse the repository at this point in the history
* spring-projectsgh-11779:
  Use try-with-resources in HttpTunnelPayload

Closes spring-projectsgh-11779
  • Loading branch information
wilkinsona committed Sep 18, 2019
2 parents 9d3586d + abcff3a commit bf56b24
Showing 1 changed file with 11 additions and 11 deletions.
Expand Up @@ -84,11 +84,11 @@ public void assignTo(HttpOutputMessage message) throws IOException {
headers.setContentLength(this.data.remaining());
headers.add(SEQ_HEADER, Long.toString(getSequence()));
headers.setContentType(MediaType.APPLICATION_OCTET_STREAM);
WritableByteChannel body = Channels.newChannel(message.getBody());
while (this.data.hasRemaining()) {
body.write(this.data);
try (WritableByteChannel body = Channels.newChannel(message.getBody())) {
while (this.data.hasRemaining()) {
body.write(this.data);
}
}
body.close();
}

/**
Expand Down Expand Up @@ -117,14 +117,14 @@ public static HttpTunnelPayload get(HttpInputMessage message) throws IOException
}
String seqHeader = message.getHeaders().getFirst(SEQ_HEADER);
Assert.state(StringUtils.hasLength(seqHeader), "Missing sequence header");
ReadableByteChannel body = Channels.newChannel(message.getBody());
ByteBuffer payload = ByteBuffer.allocate((int) length);
while (payload.hasRemaining()) {
body.read(payload);
try (ReadableByteChannel body = Channels.newChannel(message.getBody())) {
ByteBuffer payload = ByteBuffer.allocate((int) length);
while (payload.hasRemaining()) {
body.read(payload);
}
payload.flip();
return new HttpTunnelPayload(Long.valueOf(seqHeader), payload);
}
body.close();
payload.flip();
return new HttpTunnelPayload(Long.valueOf(seqHeader), payload);
}

/**
Expand Down

0 comments on commit bf56b24

Please sign in to comment.