Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promethues监控下调用方和被调用方未区分 #67

Closed
imkuqin-zw opened this issue Jun 23, 2022 · 1 comment · Fixed by #68
Closed

promethues监控下调用方和被调用方未区分 #67

imkuqin-zw opened this issue Jun 23, 2022 · 1 comment · Fixed by #68
Labels
bug Something isn't working

Comments

@imkuqin-zw
Copy link

Describe the bug
prometheus监控下被调用方和调用方取值相同
image
追踪到的可能问题代码
13532b4dd7d4dcf567652ad9cc4e50f
bc1dd7e108a3423a49f591f797a1a42

To Reproduce
Steps to reproduce the behavior.

Expected behavior
A clear and concise description of what you expected to happen.

Environment

  • Version: v1.1.0

Additional context
Add any other context about the problem here.
@imkuqin-zw imkuqin-zw added the bug Something isn't working label Jun 23, 2022
@shichaoyuan
Copy link
Member

嗯 这里可能需要分两种情况处理：

  1. 单独的 consumer，没有 caller 服务信息
  2. provider 中的 consumer，传入上下文中的服务信息

@shichaoyuan shichaoyuan mentioned this issue Jun 23, 2022
Merged
7 tasks
chuntaojun pushed a commit that referenced this issue Jun 27, 2022
@shichaoyuan
[ISSUE #67]fix prometheus caller info (#68)
cc3c854 
* fix prometheus caller info

* improve test stability

* improve test stability

* improve test stability

* improve test stability

Co-authored-by: shichaoyuan <yuan.shichao@immomo.com>
houseme added a commit to houseme/polaris-go that referenced this issue Aug 19, 2022
@houseme
Merge branch 'main' into feature/golangci
85b1191 
* main:
  [ISSUE polarismesh#71]support async register (polarismesh#72)
  feat: support env in polaris.yaml (polarismesh#77)
  feat: simplify getServices functions, remove meshconfig relative func (polarismesh#76)
  feat: support fetch all services (polarismesh#75)
  [ISSUE polarismesh#67]fix prometheus caller info (polarismesh#68)
  bugfix/timeval:fix mac_os bug
  feat：路由规则支持请求标签配置*
  feat: improve comments
  improve comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #67]fix prometheus caller info shichaoyuan/polaris-go
2 participants
@shichaoyuan @imkuqin-zw