Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

自定义探测结果 无法更新到instanceLocalValue #33

Closed
davionchen opened this issue Dec 6, 2021 · 1 comment · Fixed by #66
Closed

自定义探测结果 无法更新到instanceLocalValue #33

davionchen opened this issue Dec 6, 2021 · 1 comment · Fixed by #66
Labels
bug Something isn't working

Comments

@davionchen
Copy link
Contributor

Describe the bug
自定义探测结果 无法更新到instanceLocalValue
To Reproduce

image

自定义探测结果返回类型为:OutlierDetectionStatus,但是InstanceLocalValue的方法为setDetectResult(DetectResult result)
类型不一致性,更新失败

Expected behavior
A clear and concise description of what you expected to happen.

Environment

  • Version: [1.2.2-SNAPSHOT]

Additional context
Add any other context about the problem here.

@davionchen davionchen added the bug Something isn't working label Dec 6, 2021
@davionchen
Copy link
Contributor Author

davionchen commented Dec 7, 2021

补充一点:

调整buildInstanceUpdateResult的组装逻辑。

  properties.put(PROPERTY_DETECT_RESULT,entry.getValue());
//     new OutlierDetectionStatus(entry.getValue().getDetectType(), OutlierDetectionStatus.Status.HEALTHY,
//     entry.getValue().getLastDetectTime().getTime()));

使用如下配置:

consumer:

  outlierDetection:

    enable: true
    checkPeriod: 10000
    when: on_recover

一旦触发了探测机制,探测机制无法停止下来。

chuntaojun added a commit to chuntaojun/polaris-java that referenced this issue Mar 7, 2022
andrewshan added a commit that referenced this issue Mar 7, 2022
@chuntaojun chuntaojun linked a pull request Mar 29, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants