Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

调整leaseInfo为nil时的心跳参数处理逻辑与eureka server一致 #1007

Merged
merged 1 commit into from
Mar 15, 2023
Merged

调整leaseInfo为nil时的心跳参数处理逻辑与eureka server一致 #1007

merged 1 commit into from
Mar 15, 2023

Conversation

MI-cool
Copy link
Contributor

@MI-cool MI-cool commented Mar 15, 2023

Please provide issue(s) of this PR:
Fixes #1006

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • ApiServer

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@polaris-test-bot
Copy link

polaris-test-bot commented Mar 15, 2023

2023-03-15 18:25:21: =========TEST START==========
2023-03-15 18:25:47: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #1007 (6fe29e7) into main (a0420f6) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1007      +/-   ##
==========================================
+ Coverage   57.17%   57.19%   +0.02%     
==========================================
  Files         190      190              
  Lines       34388    34388              
==========================================
+ Hits        19660    19669       +9     
+ Misses      12162    12152      -10     
- Partials     2566     2567       +1     

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@andrewshan andrewshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewshan andrewshan merged commit 9bcda11 into polarismesh:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

兼容eureka的api遇到request body中leaseInfo为nil时心跳参数的处理和eureka server不一致
3 participants