Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增强instanceId兼容性,调整status同步逻辑 #1018

Merged
merged 6 commits into from
Mar 20, 2023
Merged

增强instanceId兼容性,调整status同步逻辑 #1018

merged 6 commits into from
Mar 20, 2023

Conversation

MI-cool
Copy link
Contributor

@MI-cool MI-cool commented Mar 17, 2023

Please provide issue(s) of this PR:
Fixes #1016

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • ApiServer

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@polaris-test-bot
Copy link

polaris-test-bot commented Mar 17, 2023

2023-03-17 17:57:31: =========TEST START==========
2023-03-17 17:57:58: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2023-03-17 19:59:12: =========TEST START==========
2023-03-17 19:59:40: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2023-03-20 12:47:19: =========TEST START==========
2023-03-20 12:47:45: Pre-Merge check fail! This branch has conflicts that must be resolved. After the conflict is resolved, we will continue to execute the test.
2023-03-20 14:47:08: =========TEST START==========
2023-03-20 14:47:34: Pre-Merge check fail! This branch has conflicts that must be resolved. After the conflict is resolved, we will continue to execute the test.
2023-03-20 16:52:16: =========TEST START==========
2023-03-20 16:52:46: Pre-Merge check fail! This branch has conflicts that must be resolved. After the conflict is resolved, we will continue to execute the test.
2023-03-20 17:52:30: =========TEST START==========
2023-03-20 17:52:56: Pre-Merge check fail! This branch has conflicts that must be resolved. After the conflict is resolved, we will continue to execute the test.

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #1018 (d0f07a1) into main (71a86a8) will increase coverage by 0.69%.
The diff coverage is n/a.

❗ Current head d0f07a1 differs from pull request most recent head 0fb7c00. Consider uploading reports for the commit 0fb7c00 to get more accurate results

@@            Coverage Diff             @@
##             main    #1018      +/-   ##
==========================================
+ Coverage   57.22%   57.92%   +0.69%     
==========================================
  Files         190      191       +1     
  Lines       34380    34400      +20     
==========================================
+ Hits        19673    19925     +252     
+ Misses      12141    11885     -256     
- Partials     2566     2590      +24     

see 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

apiserver/eurekaserver/server.go Outdated Show resolved Hide resolved
@chuntaojun
Copy link
Member

修复下 golangci-lint 的问题。先执行 bash import-format.sh 格式化 import 的顺序

@chuntaojun chuntaojun merged commit 55fe201 into polarismesh:main Mar 20, 2023
chuntaojun pushed a commit to chuntaojun/polaris that referenced this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eureka服务只要求instanceId在同服务内唯一,北极星要求全局唯一
4 participants