Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #996] Remove unused code #1020

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Conversation

Cshiyuan
Copy link
Contributor

Please provide issue(s) of this PR:
Fixes #996

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • ApiServer
  • Auth
  • Configuration
  • Naming
  • HealthCheck
  • Metrics
  • Docs
  • Installation
  • Performance and Scalability
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@polaris-test-bot
Copy link

polaris-test-bot commented Mar 18, 2023

2023-03-18 15:44:43: =========TEST START==========
2023-03-18 15:45:09: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2023-03-18 15:59:30: [STANDALONE VERSION]PR autotest PASSED! We executed 20 test cases and 20 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1280995134/sta/qta-report.html
2023-03-18 15:59:34: [CLUSTER VERSION] PR autotest PASSED! We executed 20 test cases and 20 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1280995134/clu/qta-report.html
2023-03-18 15:59:38: [KUBENETES VERSION]PR autotest PASSED! We executed 20 test cases and 20 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1280995134/k8s/qta-report.html

@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Merging #1020 (7856279) into main (30811f9) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
- Coverage   57.37%   57.35%   -0.02%     
==========================================
  Files         191      191              
  Lines       34409    34401       -8     
==========================================
- Hits        19742    19731      -11     
  Misses      12096    12096              
- Partials     2571     2574       +3     
Impacted Files Coverage Δ
service/ratelimit_config.go 63.92% <ø> (+0.26%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chuntaojun chuntaojun merged commit c72da34 into polarismesh:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

反馈一段无效代码
3 participants