Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 解决健康检查规则打印时候出现的协程panic问题 #1024

Merged
merged 2 commits into from
Mar 20, 2023
Merged

fix: 解决健康检查规则打印时候出现的协程panic问题 #1024

merged 2 commits into from
Mar 20, 2023

Conversation

andrewshan
Copy link
Member

@andrewshan andrewshan commented Mar 19, 2023

fix: 修复健康检查规则报错问题

Please provide issue(s) of this PR:
Fixes #

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • ApiServer
  • Auth
  • Configuration
  • Naming
  • HealthCheck
  • Metrics
  • Docs
  • Installation
  • Performance and Scalability
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

fix: 修复健康检查规则报错问题
@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Merging #1024 (f011153) into release-v1.15.0 (248df93) will increase coverage by 0.55%.
The diff coverage is 100.00%.

@@                 Coverage Diff                 @@
##           release-v1.15.0    #1024      +/-   ##
===================================================
+ Coverage            57.26%   57.82%   +0.55%     
===================================================
  Files                  190      190              
  Lines                34379    34381       +2     
===================================================
+ Hits                 19688    19880     +192     
+ Misses               12120    11911     -209     
- Partials              2571     2590      +19     
Impacted Files Coverage Δ
cache/faultdetect.go 63.72% <ø> (+45.66%) ⬆️
service/healthcheck/server.go 30.81% <100.00%> (+1.22%) ⬆️

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chuntaojun chuntaojun merged commit e1038f0 into polarismesh:release-v1.15.0 Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants