Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow empty db password #1237

Merged
merged 1 commit into from Sep 7, 2023

Conversation

WTIFS
Copy link
Contributor

@WTIFS WTIFS commented Sep 5, 2023

Please provide issue(s) of this PR:
Fixes #1236

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • ApiServer
  • Auth
  • Configuration
  • Naming
  • HealthCheck
  • Metrics
  • Docs
  • Installation
  • Performance and Scalability
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@polaris-test-bot
Copy link

polaris-test-bot commented Sep 5, 2023

2023-09-05 16:37:00: =========TEST START==========
2023-09-05 17:34:17: [STANDALONE VERSION]PR autotest FAILED! We executed 47 test cases and 43 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1502377927/sta/qta-report.html and https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1502377927/sta/ratelimit/qta-report.html
2023-09-05 17:34:21: [CLUSTER VERSION] PR autotest FAILED! We executed 39 test cases and 35 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1502377927/clu/qta-report.html
2023-09-05 17:34:25: [KUBENETES VERSION]PR autotest FAILED! We executed 39 test cases and 36 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1502377927/k8s/qta-report.html

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #1237 (82c6610) into main (eb3a9cc) will increase coverage by 0.09%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
+ Coverage   55.78%   55.87%   +0.09%     
==========================================
  Files         179      179              
  Lines       32438    32442       +4     
==========================================
+ Hits        18094    18127      +33     
+ Misses      11987    11963      -24     
+ Partials     2357     2352       -5     
Files Changed Coverage Δ
store/mysql/default.go 73.36% <40.00%> (-1.08%) ⬇️

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chuntaojun chuntaojun merged commit c620da9 into polarismesh:main Sep 7, 2023
9 of 11 checks passed
@WTIFS WTIFS deleted the feat.allow_empty_pwd branch September 7, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

配置中允许不设置MySQL密码
3 participants